meet-the-team #582

Merged
tcsrikan merged 11 commits from meet-the-team into main 2023-06-04 17:36:47 -04:00
Member

Closes #581

Closes #581
tcsrikan added 8 commits 2023-06-03 18:12:00 -04:00
tcsrikan requested review from a258wang 2023-06-03 18:12:12 -04:00
a258wang reviewed 2023-06-04 01:01:09 -04:00
@ -23,3 +19,1 @@
},
{
"name": "Annie Zhang",
"name": "Bonnie Pend",
Owner

typo, should be Bonnie Peng

typo, should be `Bonnie Peng`
a258wang marked this conversation as resolved
a258wang reviewed 2023-06-04 01:01:33 -04:00
@ -33,3 +33,3 @@
},
{
"name": "Sat Arora",
"name": "Ivy lei",
Owner

typo, should be Ivy Lei (capital L)

typo, should be `Ivy Lei` (capital L)
a258wang marked this conversation as resolved
a258wang reviewed 2023-06-04 01:04:16 -04:00
@ -14,3 +13,4 @@
"name": "Jinal Rajwat"
},
{
"name": "Devin Li"
Owner

should remove Devin here, since he's already listed as team lead

should remove Devin here, since he's already listed as team lead
a258wang marked this conversation as resolved
a258wang reviewed 2023-06-04 01:05:45 -04:00
@ -15,0 +14,4 @@
"name": "Krish Arora"
},
{
"name": "Ksharma Patel"
Owner

typo, should be Kshama Patel

typo, should be `Kshama Patel`
a258wang marked this conversation as resolved
a258wang reviewed 2023-06-04 01:14:44 -04:00
@ -21,0 +23,4 @@
},
{
"name": "Lila Hoang"
},
Owner

also need to add Prabhsharan Singh Sethi

also need to add `Prabhsharan Singh Sethi`
Owner

you'll also probably need to specify the image file name manually for Prabhsharan, OR fix the getMemberImagePath function to look for a file called PrabhsharanSinghSethi.<png|jpg|jpeg|gif>

you'll also probably need to specify the image file name manually for Prabhsharan, OR fix the `getMemberImagePath` function to look for a file called `PrabhsharanSinghSethi.<png|jpg|jpeg|gif>`
Author
Member

I added the image file name manually. Do you know what the issue was with the file name, so that I can also change getMemberImagePath to make it work.

I added the image file name manually. Do you know what the issue was with the file name, so that I can also change getMemberImagePath to make it work.
Owner

yes i do know what the issue is with getMemberImagePath and why it won't detect this particular image file automatically, i will leave it as an exercise in case you'd like to figure it out for yourself 🙃

(let me know if you want the answer lol)

yes i do know what the issue is with `getMemberImagePath` and why it won't detect this particular image file automatically, i will leave it as an exercise in case you'd like to figure it out for yourself 🙃 (let me know if you want the answer lol)
a258wang reviewed 2023-06-04 01:15:37 -04:00
@ -1,14 +1,11 @@
[
{
"name": "Laura Nguyen",
"name": "Andrew Wang",
Owner

i just realized this file can be deleted LOL, Discord mods aren't listed on the website

i just realized this file can be deleted LOL, Discord mods aren't listed on the website
a258wang marked this conversation as resolved
Owner

the following images should be renamed:

  • LilaHoàng.jpg -> LilaHoang.jpg
  • Prabhsharan Singh Sethi.jpeg -> PrabhsharanSinghSethi.jpeg
the following images should be renamed: - `LilaHoàng.jpg` -> `LilaHoang.jpg` - `Prabhsharan Singh Sethi.jpeg` -> `PrabhsharanSinghSethi.jpeg`
Owner

if we could update Joshua's exec blurb as well, that'd be great, ty :))
here is the blurb: https://discord.com/channels/967247944401158174/977713509955698758/1110394369518874626

if we could update Joshua's exec blurb as well, that'd be great, ty :)) here is the blurb: https://discord.com/channels/967247944401158174/977713509955698758/1110394369518874626
tcsrikan added 1 commit 2023-06-04 10:15:11 -04:00
continuous-integration/drone/push Build is failing Details
67eb209cf2
fix typos, add josh blurb
Author
Member

Alright, fixed the typos, thanks for catching those!

Alright, fixed the typos, thanks for catching those!
Owner
build is failing: https://ci.csclub.uwaterloo.ca/www/www-new/2073/1/8
a258wang approved these changes 2023-06-04 13:47:34 -04:00
a258wang left a comment
Owner

the build step in CI is failing, once that's fixed then feel free to merge! :)

the build step in CI is failing, once that's fixed then feel free to merge! :)
tcsrikan added 1 commit 2023-06-04 14:24:32 -04:00
continuous-integration/drone/push Build is passing Details
eda25404b5
remove discord mod import
tcsrikan added 1 commit 2023-06-04 14:29:45 -04:00
continuous-integration/drone/push Build is passing Details
71934acd08
remove import line
tcsrikan merged commit 0e5b18ffdd into main 2023-06-04 17:36:47 -04:00
tcsrikan referenced this issue from a commit 2023-06-04 17:36:48 -04:00
Sign in to join this conversation.
No reviewers
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: www/www-new#582
No description provided.