www
/
www-new
15
3
Fork 8
Code Issues 60 Pull Requests 52 Projects Releases Wiki Activity

Mobile Mini Event Card #97

Merged
l42luo merged 9 commits from feat/mobile-mini-event-card into main 2021-08-16 20:23:42 -04:00
Conversation 0 Commits 9 Files Changed 2 +22 -3
l42luo commented 2021-07-25 15:06:08 -04:00
Member
Copy Link

Closes #38

Currently short description is still visible when card is closed

Closes #38 Currently short description is still visible when card is closed
l42luo added 2 commits 2021-07-25 15:06:09 -04:00
continuous-integration/drone/push Build is passing Details
65217ea597 cleaned up css module
l42luo reviewed 2021-07-25 15:07:36 -04:00
components/MiniEventCard.module.css Outdated
@ -51,0 +65,4 @@
@media only screen and (max-width: calc(768rem / 16)) {
.mobileOpenCardToggle {
position: relative;
margin: auto;
l42luo commented 2021-07-25 15:07:36 -04:00
Author
Member
Copy Link

This aligns View Details with rest of text on the card

This aligns `View Details` with rest of text on the card
l42luo added 1 commit 2021-07-25 15:09:48 -04:00
continuous-integration/drone/push Build is passing Details
97cc93daeb Merge branch 'main' into feat/mobile-mini-event-card 
merge feat/mobile-mini-event-card with main branch
l42luo changed title from WIP: Mobile Mini Event Card to Mobile Mini Event Card 2021-07-26 22:33:12 -04:00
l42luo added 1 commit 2021-07-30 17:24:59 -04:00
continuous-integration/drone/push Build is passing Details
310c9c2bcf Merge branch 'main' into feat/mobile-mini-event-card
a3thakra reviewed 2021-08-01 18:43:51 -04:00
components/MiniEventCard.tsx Outdated
@ -37,3 +37,2 @@
<p className={styles.mobileOpenCardToggle}>View details</p>
</summary>
<div>{description}</div>
a3thakra commented 2021-08-01 18:43:51 -04:00
Owner
Copy Link

Semantically, this is not correct. Everything in the <summary> should be the short description, and everything outside the <summary> but inside the <details> should be the full explanation.

Semantically, this is not correct. Everything in the `<summary>` should be the short description, and everything outside the `<summary>` but inside the `<details>` should be the full explanation.
a3thakra reviewed 2021-08-01 18:50:40 -04:00
components/MiniEventCard.tsx Outdated
@ -35,2 +35,3 @@
<p className={styles.details}>View details {dropDownIcon}</p>
<div className={styles.longDescription}>{description}</div>
<p className={styles.mobileOpenCardToggle}>View details</p>
a3thakra commented 2021-08-01 18:50:40 -04:00
Owner
Copy Link

Duplicating UI for mobile is a bad practice. You can wrap up the dropdown icon in a <span> and then slap a class on that span, and display: none that class on mobile.

Duplicating UI for mobile is a bad practice. You can wrap up the dropdown icon in a `<span>` and then slap a class on that span, and `display: none` that class on mobile.
l42luo added the due date 2021-08-05 2021-08-02 20:47:26 -04:00
l42luo removed the due date 2021-08-05 2021-08-13 12:46:04 -04:00
l42luo added the due date 2021-08-16 2021-08-13 12:46:08 -04:00
l42luo added 6 commits 2021-08-15 19:03:46 -04:00
continuous-integration/drone/push Build is passing Details
6d5de0ff7e Upgrade Next, React, TypeScript (#91) 
closes #41

# Steps for reviewing

1. `git checkout adi-upgrade-deps`
1. `git clean -xfd`
1. `npm i`
1. `npm run dev`
1. make sure everything looks normal

Reviewed-on: #91
Reviewed-by: n3parikh <n3parikh@localhost>
Co-authored-by: Aditya Thakral <a3thakra@csclub.uwaterloo.ca>
Co-committed-by: Aditya Thakral <a3thakra@csclub.uwaterloo.ca>
continuous-integration/drone/push Build is passing Details
c4c0be9861 Update dependency eslint to v7.32.0 (#121) 
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [eslint](https://eslint.org) ([source](https://github.com/eslint/eslint)) | devDependencies | minor | [`7.31.0` -> `7.32.0`](https://renovatebot.com/diffs/npm/eslint/7.31.0/7.32.0) |

⚠️ Release Notes retrieval for this PR were skipped because no github.com credentials were available.
If you are using the hosted GitLab app, please follow [this guide](https://docs.renovatebot.com/install-gitlab-app/#configuring-a-token-for-githubcom-hosted-release-notes). If you are self-hosted, please see [this instruction](https://github.com/renovatebot/renovate/blob/master/docs/usage/self-hosting.md#githubcom-token-for-release-notes) instead.

---

### Configuration

📅 **Schedule**: At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box.

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

Reviewed-on: #121
Co-authored-by: Renovate Bot <no-reply@csclub.uwaterloo.ca>
Co-committed-by: Renovate Bot <no-reply@csclub.uwaterloo.ca>
continuous-integration/drone/push Build is passing Details
b281572116 Script to deploy site to your CSC website (#99) 
Co-authored-by: Neil Parikh <n3parikh@csclub.uwaterloo.ca>
Reviewed-on: #99
Reviewed-by: Aditya Thakral <a3thakra@csclub.uwaterloo.ca>
Co-authored-by: n3parikh <n3parikh@localhost>
Co-committed-by: n3parikh <n3parikh@localhost>
continuous-integration/drone/push Build is passing Details
af8c750c0c Change CSS variable names + create a themer (#109) 
Try it out at https://csclub.uwaterloo.ca/~a3thakra/website-demo/themer/

- Themes persist across website reloads
- Individual color reset buttons
- Reset all colors button

Reviewed-on: #109
Reviewed-by: n3parikh <n3parikh@localhost>
Reviewed-by: b38peng <b38peng@uwaterloo.ca>
Co-authored-by: Aditya Thakral <a3thakra@csclub.uwaterloo.ca>
Co-committed-by: Aditya Thakral <a3thakra@csclub.uwaterloo.ca>
continuous-integration/drone/push Build is passing Details
f18c227b1e Merge branch 'main' into feat/mobile-mini-event-card
l42luo added 1 commit 2021-08-16 16:35:28 -04:00
continuous-integration/drone/push Build is failing Details
3e700c7a3c removed duplication of UI
l42luo added 1 commit 2021-08-16 16:36:21 -04:00
continuous-integration/drone/push Build is failing Details
31916bb373 Merge branch 'main' into feat/mobile-mini-event-card
l42luo added 1 commit 2021-08-16 16:42:42 -04:00
continuous-integration/drone/push Build is passing Details
649a641411 fix prettier issue
a3thakra approved these changes 2021-08-16 20:22:32 -04:00
a3thakra left a comment
Owner
Copy Link

LGTM! Hit the button!

LGTM! Hit the button!
l42luo merged commit 2ced987f42 into main 2021-08-16 20:23:42 -04:00
l42luo referenced this issue from a commit 2021-08-16 20:23:42 -04:00
Mobile Mini Event Card (#97)
l42luo deleted branch feat/mobile-mini-event-card 2021-08-16 20:24:01 -04:00
Sign in to join this conversation.
Reviewers
No reviewers
a3thakra
Labels
Clear labels   
a11y

   
Backlog

   
Blocked

   
Bug

   
Content

   
Dependencies

   
Design

   
Feature Request

   
Good First Issue

   
In Progress

   
Performance

   
Priority - High

   
Priority - Low

   
Priority - Medium

   
Untriaged
No Label
a11y
Backlog
Blocked
Bug
Content
Dependencies
Design
Feature Request
Good First Issue
In Progress
Performance
Priority - High
Priority - Low
Priority - Medium
Untriaged
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

2021-08-16

Dependencies

No dependencies set.

Reference: www/www-new#97
No description provided.
Delete Branch "feat/mobile-mini-event-card"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?