Mobile Mini Event Card #97
Merged
l42luo
merged 9 commits from feat/mobile-mini-event-card
into main
2 years ago
Loading…
Reference in new issue
There is no content yet.
Delete Branch 'feat/mobile-mini-event-card'
Deleting a branch is permanent. It CANNOT be undone. Continue?
Closes #38
Currently short description is still visible when card is closed
@media only screen and (max-width: calc(768rem / 16)) {
.mobileOpenCardToggle {
position: relative;
margin: auto;
This aligns
View Details
with rest of text on the cardWIP: Mobile Mini Event Cardto Mobile Mini Event Card 2 years ago<p className={styles.mobileOpenCardToggle}>View details</p>
</summary>
<div>{description}</div>
Semantically, this is not correct. Everything in the
<summary>
should be the short description, and everything outside the<summary>
but inside the<details>
should be the full explanation.<p className={styles.details}>View details {dropDownIcon}</p>
<div className={styles.longDescription}>{description}</div>
<p className={styles.mobileOpenCardToggle}>View details</p>
Duplicating UI for mobile is a bad practice. You can wrap up the dropdown icon in a
<span>
and then slap a class on that span, anddisplay: none
that class on mobile.LGTM! Hit the button!
2ced987f42
into main 2 years agoReviewers
2ced987f42
.