Mobile Mini Event Card #97

Merged
l42luo merged 9 commits from feat/mobile-mini-event-card into main 1 year ago
l42luo commented 2 years ago
Collaborator

Closes #38

Currently short description is still visible when card is closed

Closes #38 Currently short description is still visible when card is closed
l42luo added 2 commits 2 years ago
l42luo reviewed 2 years ago
@media only screen and (max-width: calc(768rem / 16)) {
.mobileOpenCardToggle {
position: relative;
margin: auto;
Poster
Collaborator

This aligns View Details with rest of text on the card

This aligns `View Details` with rest of text on the card
l42luo added 1 commit 2 years ago
97cc93daeb Merge branch 'main' into feat/mobile-mini-event-card
l42luo changed title from WIP: Mobile Mini Event Card to Mobile Mini Event Card 2 years ago
l42luo added 1 commit 2 years ago
310c9c2bcf Merge branch 'main' into feat/mobile-mini-event-card
a3thakra reviewed 2 years ago
<p className={styles.mobileOpenCardToggle}>View details</p>
</summary>
<div>{description}</div>
Collaborator

Semantically, this is not correct. Everything in the <summary> should be the short description, and everything outside the <summary> but inside the <details> should be the full explanation.

Semantically, this is not correct. Everything in the `<summary>` should be the short description, and everything outside the `<summary>` but inside the `<details>` should be the full explanation.
a3thakra reviewed 2 years ago
<p className={styles.details}>View details {dropDownIcon}</p>
<div className={styles.longDescription}>{description}</div>
<p className={styles.mobileOpenCardToggle}>View details</p>
Collaborator

Duplicating UI for mobile is a bad practice. You can wrap up the dropdown icon in a <span> and then slap a class on that span, and display: none that class on mobile.

Duplicating UI for mobile is a bad practice. You can wrap up the dropdown icon in a `<span>` and then slap a class on that span, and `display: none` that class on mobile.
l42luo added the due date 2021-08-05 2 years ago
l42luo removed the due date 2021-08-05 1 year ago
l42luo added the due date 2021-08-16 1 year ago
l42luo added 6 commits 1 year ago
6d5de0ff7e Upgrade Next, React, TypeScript (#91)
c4c0be9861 Update dependency eslint to v7.32.0 (#121)
b281572116 Script to deploy site to your CSC website (#99)
af8c750c0c Change CSS variable names + create a themer (#109)
f18c227b1e Merge branch 'main' into feat/mobile-mini-event-card
l42luo added 1 commit 1 year ago
3e700c7a3c removed duplication of UI
l42luo added 1 commit 1 year ago
31916bb373 Merge branch 'main' into feat/mobile-mini-event-card
l42luo added 1 commit 1 year ago
649a641411 fix prettier issue
a3thakra approved these changes 1 year ago
a3thakra left a comment
Collaborator

LGTM! Hit the button!

LGTM! Hit the button!
l42luo merged commit 2ced987f42 into main 1 year ago
l42luo referenced this issue from a commit 1 year ago
l42luo deleted branch feat/mobile-mini-event-card 1 year ago

Reviewers

a3thakra approved these changes 1 year ago
continuous-integration/drone/push Build is passing
The pull request has been merged as 2ced987f42.
Sign in to join this conversation.
No reviewers
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date

2021-08-16

Dependencies

No dependencies set.

Reference: www/www-new#97
Loading…
There is no content yet.