www
/
cs-2022-class-profile
16
0
Fork 0
Code Issues 11 Pull Requests 1 Projects Releases Wiki Activity

Changed academic average bar graph colors #160

Merged
dlslo merged 2 commits from darren/change-graph-colors into main 2023-02-04 16:39:17 -05:00
Conversation 1 Commits 2 Files Changed 3 +19 -2
dlslo commented 2023-02-01 17:45:01 -05:00
Member
Copy Link

Closes #146

https://darren-change-graph-colors-csc-class-profile-snedadah.k8s.csclub.cloud/

Closes #146 https://darren-change-graph-colors-csc-class-profile-snedadah.k8s.csclub.cloud/
dlslo added 1 commit 2023-02-01 17:45:03 -05:00
continuous-integration/drone/push Build is passing Details
b383a38f4d Changed academic average bar graph colors
dlslo requested review from snedadah 2023-02-01 17:45:28 -05:00
dlslo requested review from e26chiu 2023-02-01 17:45:28 -05:00
snedadah approved these changes 2023-02-03 00:21:58 -05:00
Dismissed
snedadah left a comment
Owner
Copy Link

Its looking a bit strange for me on staging for some reason

image

Its looking a bit strange for me on staging for some reason ![image](/attachments/ebd8bb15-3c8f-4532-84c8-90a78d304ae7)
snedadah reviewed 2023-02-03 00:21:59 -05:00
snedadah left a comment
Owner
Copy Link

Its looking a bit strange for me on staging for some reason

image

Its looking a bit strange for me on staging for some reason ![image](/attachments/ebd8bb15-3c8f-4532-84c8-90a78d304ae7)
snedadah reviewed 2023-02-03 00:21:59 -05:00
snedadah left a comment
Owner
Copy Link

Its looking a bit strange for me on staging for some reason

image

Its looking a bit strange for me on staging for some reason ![image](/attachments/ebd8bb15-3c8f-4532-84c8-90a78d304ae7)
snedadah reviewed 2023-02-03 00:21:59 -05:00
snedadah left a comment
Owner
Copy Link

Its looking a bit strange for me on staging for some reason

image

Its looking a bit strange for me on staging for some reason ![image](/attachments/ebd8bb15-3c8f-4532-84c8-90a78d304ae7)
snedadah reviewed 2023-02-03 00:22:00 -05:00
snedadah left a comment
Owner
Copy Link

Its looking a bit strange for me on staging for some reason

image

Its looking a bit strange for me on staging for some reason ![image](/attachments/ebd8bb15-3c8f-4532-84c8-90a78d304ae7)
snedadah reviewed 2023-02-03 00:22:00 -05:00
snedadah left a comment
Owner
Copy Link

Its looking a bit strange for me on staging for some reason

image

Its looking a bit strange for me on staging for some reason ![image](/attachments/ebd8bb15-3c8f-4532-84c8-90a78d304ae7)
snedadah reviewed 2023-02-03 00:22:00 -05:00
snedadah left a comment
Owner
Copy Link

Its looking a bit strange for me on staging for some reason

image

Its looking a bit strange for me on staging for some reason ![image](/attachments/ebd8bb15-3c8f-4532-84c8-90a78d304ae7)
image.png
16 KiB
snedadah dismissed snedadah’s review 2023-02-03 00:22:26 -05:00
Reason:

accidental approval

snedadah commented 2023-02-03 00:24:03 -05:00
Owner
Copy Link

Sorry for the spam, gittea bugs...
For somerason it looks like the colros areant showing up on staging (https://darren-change-graph-colors-csc-class-profile-snedadah.k8s.csclub.cloud/) I can help you debug more later if needed.

Sorry for the spam, gittea bugs... For somerason it looks like the colros areant showing up on staging (https://darren-change-graph-colors-csc-class-profile-snedadah.k8s.csclub.cloud/) I can help you debug more later if needed.
image.png
16 KiB
image.png
e26chiu requested changes 2023-02-04 12:47:14 -05:00
e26chiu left a comment
Contributor
Copy Link

I noticed the same problem as @snedadah . You can check my comments below for hints. Otherwise, LGTM!

I noticed the same problem as @snedadah . You can check my comments below for hints. Otherwise, LGTM!
pages/_app.css
@ -37,2 +38,4 @@
--dark--primary-accent-light: var(--light-pink);
--dark--primary-accent-lighter: var(--lighter-pink);
--dark--primary-accent-dark: #dc538e;
--dark--primary-accent-darker: #c8417c;
e26chiu commented 2023-02-04 12:45:39 -05:00
Contributor
Copy Link

Make sure you define the default value for primary-accent-dark and primary-accent-darker in body so that these colours can be properly displayed.

Make sure you define the default value for `primary-accent-dark` and `primary-accent-darker` in body so that these colours can be properly displayed.
pages/_app.css
@ -140,3 +145,4 @@
--primary-accent-darker: var(--dark--primary-accent-darker);
--secondary-accent: var(--dark--secondary-accent);
--secondary-accent-light: var(--dark--secondary-accent-light);
--secondary-accent-dark: var(--primary-accent-dark);
e26chiu commented 2023-02-04 12:46:40 -05:00
Contributor
Copy Link

This line was leftover code that I noticed isn't being used anywhere else. You can delete it in this PR. Thanks!

This line was leftover code that I noticed isn't being used anywhere else. You can delete it in this PR. Thanks!
dlslo added 1 commit 2023-02-04 13:53:51 -05:00
continuous-integration/drone/push Build is passing Details
ca606a015d Fixed default colors
snedadah approved these changes 2023-02-04 16:03:47 -05:00
snedadah left a comment
Owner
Copy Link

Nice work! Seems to be fixed now!

Nice work! Seems to be fixed now!
dlslo merged commit 71f9125bf2 into main 2023-02-04 16:39:17 -05:00
dlslo deleted branch darren/change-graph-colors 2023-02-04 16:39:17 -05:00
Sign in to join this conversation.
Reviewers
No reviewers
e26chiu
snedadah
Labels
Clear labels   
Bug

   
Component

   
Config

   
Good First Issue

   
Low-Priority

   
Page
No Label
Bug
Component
Config
Good First Issue
Low-Priority
Page
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: www/cs-2022-class-profile#160
No description provided.
Delete Branch "darren/change-graph-colors"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?