Add SectionHeader component (Closes #74) #75
Loading…
Reference in New Issue
No description provided.
Delete Branch "sectionheader-component"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
This PR adds the SectionHeader component as described in the issue. The text is centered, so it's adapted for mobile. Possible improvements (or nitpicks) would be to add spacing around the text in mobile version (left and right margin/padding) or maybe make the title or subtitle smaller? I think it looks fine otherwise. Let me know what you think.
https://sectionheader-component-csc-class-profile-st-snedadah.k8s.csclub.cloud/
LGTM other than two small comments!
@ -0,0 +18,4 @@
margin: auto;
}
.graphContainer {
I think this style was left here on accident?
Yeah, I left it there by accident from my other PR. Thanks for noticing!
@ -0,0 +4,4 @@
interface SectionHeaderProps {
title: string;
subtitle: string;
We should probably make this optional, for example, for the contributors page it might not be needed?
Yup, I'll make the subtitle optional! Nice catch!