www
/
cs-2022-class-profile
16
0
Fork 0
Code Issues 11 Pull Requests 1 Projects Releases Wiki Activity

Add Contributors page (Closes #63) #121

Merged
snedadah merged 4 commits from contributors-page into main 2022-12-30 18:49:11 -05:00
Conversation 0 Commits 4 Files Changed 3 +165
e26chiu commented 2022-12-28 22:26:50 -05:00
Contributor
Copy Link
No description provided.
e26chiu added 1 commit 2022-12-28 22:26:51 -05:00
continuous-integration/drone/push Build is passing Details
d4806921d8 Add Contributors page
e26chiu added 1 commit 2022-12-28 22:27:04 -05:00
continuous-integration/drone/push Build is passing Details
6449fde642 Merge branch 'main' into contributors-page
snedadah approved these changes 2022-12-29 02:52:11 -05:00
snedadah left a comment
Owner
Copy Link

Looking good!

Looking good!
data/contributors.ts
@ -0,0 +1,75 @@
export const communityReps = [
{
snedadah commented 2022-12-29 02:48:17 -05:00
Owner
Copy Link

I think we should orginize these names alphabetically (in each section)? You could do it in code (check the below) since for example some teams have had multiple leads in the time frame, such as Amy L and Sat

I think we should orginize these names alphabetically (in each section)? You could do it in code (check the below) since for example some teams have had multiple leads in the time frame, such as Amy L and Sat
pages/contributors.tsx Outdated
@ -0,0 +21,4 @@
export function ContributorGroup({ group }: ContributorGroupProps) {
return (
<ul>
{group.map((d, idx) => {
snedadah commented 2022-12-29 02:50:14 -05:00
Owner
Copy Link

You can simply do the sorting here by : group.sort((a, b) => a.name.localeCompare(b.name));

https://stackoverflow.com/questions/1129216/sort-array-of-objects-by-string-property-value

You can simply do the sorting here by : group.sort((a, b) => a.name.localeCompare(b.name)); https://stackoverflow.com/questions/1129216/sort-array-of-objects-by-string-property-value
pages/contributors.tsx
@ -0,0 +74,4 @@
</ul>
</CenterWrapper>
<BottomNav leftPage={pageRoutes.personal}></BottomNav>
snedadah commented 2022-12-29 02:51:46 -05:00
Owner
Copy Link

I think we should also add an arrow to Home to the right. (if pageRoutes doesnt have home add it)

I think we should also add an arrow to Home to the right. (if pageRoutes doesnt have home add it)
snedadah reviewed 2022-12-29 04:13:10 -05:00
pages/contributors.tsx
@ -0,0 +41,4 @@
subtitle="Huge thanks to all CSC members who have contributed to creating the first ever uWaterloo CS class profile!"
/>
<CenterWrapper>
snedadah commented 2022-12-29 04:13:10 -05:00
Owner
Copy Link

btw this has a centering issue on mobile but I think I fixed it for the front page PR

btw this has a centering issue on mobile but I think I fixed it for the front page PR
e26chiu added 2 commits 2022-12-29 10:26:23 -05:00
snedadah merged commit 85535414c3 into main 2022-12-30 18:49:11 -05:00
snedadah deleted branch contributors-page 2022-12-30 18:49:11 -05:00
Sign in to join this conversation.
Reviewers
No reviewers
snedadah
Labels
Clear labels   
Bug

   
Component

   
Config

   
Good First Issue

   
Low-Priority

   
Page
No Label
Bug
Component
Config
Good First Issue
Low-Priority
Page
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: www/cs-2022-class-profile#121
No description provided.
Delete Branch "contributors-page"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?