www
/
cs-2022-class-profile
16
0
Fork 0
Code Issues 11 Pull Requests Projects Releases Wiki Activity
Labels Milestones

Fix weird percentage number and add percent symbol #157

Merged
snedadah merged 3 commits from shahanneda/fix-percent into main 2 months ago
Conversation 0 Commits 3 Files Changed 4
snedadah commented 2 months ago
Owner

image

image

![image](/attachments/956151a0-270d-4d46-9985-73c24806e338) ![image](/attachments/f00e1266-8d16-46cd-9408-9955c93c3dd2)
snedadah added 1 commit 2 months ago
continuous-integration/drone/push Build is passing
Details
00f3950106 Commited changes
snedadah requested review from e26chiu 2 months ago
e26chiu added 1 commit 2 months ago
continuous-integration/drone/push Build is passing
Details
e4a1154032 Fix tooltip formatting + calibrate data
e26chiu approved these changes 2 months ago
e26chiu left a comment
Collaborator

@snedadah I have only one question regarding hiding data value. I also added labels to other tooltips and adjusted the data for one of the stacked bar graph (from 0.01 to 1) to match the other percentages of data. Nothing blocking this from being merged though. Good job!

@snedadah I have only one question regarding hiding data value. I also added labels to other tooltips and adjusted the data for one of the stacked bar graph (from 0.01 to 1) to match the other percentages of data. Nothing blocking this from being merged though. Good job!
pages/coop.tsx Outdated
]}
data={C7v}
margin={barGraphMargin}
hideDataValueInTooltip
e26chiu commented 2 months ago
Collaborator

I'm not sure I understand why we are hiding the data value for this specific graph tooltip?

I'm not sure I understand why we are hiding the data value for this specific graph tooltip?
snedadah commented 2 months ago
Poster
Owner

The original plan was to use hide this one, but then since I added the percentage option, which is better. So good point, I changed it to percentage (thanks for changing the data).

The original plan was to use hide this one, but then since I added the percentage option, which is better. So good point, I changed it to percentage (thanks for changing the data).
snedadah added 1 commit 2 months ago
continuous-integration/drone/push Build is passing
Details
bc3f8d5eaa Changed hide to percentage
snedadah merged commit 1a6d031dd6 into main 2 months ago
snedadah deleted branch shahanneda/fix-percent 2 months ago

Reviewers

e26chiu approved these changes 2 months ago
continuous-integration/drone/push Build is passing
Details
The pull request has been merged as 1a6d031dd6.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
e26chiu
Labels
Apply labels
Clear labels
Bug Component Config Good First Issue Low-Priority Page
No Label Bug Component Config Good First Issue Low-Priority Page
Milestone
Set milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: www/cs-2022-class-profile#157
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'shahanneda/fix-percent'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes