www
/
cs-2022-class-profile
16
0
Fork 0
Code Issues 11 Pull Requests 1 Projects Releases Wiki Activity

Add About Component #48

Merged
j285he merged 7 commits from j285he-about into main 2022-09-12 10:20:11 -04:00
Conversation 1 Commits 7 Files Changed 4 +15 -11
1 changed files with 15 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 5657414036 - Show all commits

26
components/About.module.css
View File

@ -9,25 +9,29 @@
padding: calc(45rem / 16);
j285he marked this conversation as resolved
a258wang commented 2022-09-03 01:14:05 -04:00
Review
Copy Link

Is there any reason why we aren't doing width: 100% (or maybe it's not even necessary to specify the width) and then just letting padding/margin handle the spacing?

Is there any reason why we aren't doing `width: 100%` (or maybe it's not even necessary to specify the width) and then just letting padding/margin handle the spacing?
}
.about aside {
flex: 1;
margin-right: 40px;
}
.about h1 {
margin: 0;
}
j285he marked this conversation as resolved
a258wang commented 2022-09-11 02:30:27 -04:00
Review
Copy Link

NIT: rem

NIT: rem
.about article {
flex: 3;
}
.about h4 {
margin: 0;
}
.about aside {
flex: 1;
margin-right: calc(40rem / 16);
}
.about aside h1 {
color: var(--secondary-accent)
}
.about aside p {
color: var(--primary-accent-light)
color: var(--primary-accent-lighter)
}
.about article {
flex: 3;
}
.about article p {
@ -43,7 +47,7 @@
}
.anglePath {
stroke: var(--primary-accent)
stroke: var(--primary-accent-light)
}
.left.angle {