www
/
cs-2022-class-profile
16
0
Fork 0
Code Issues 11 Pull Requests 1 Projects Releases Wiki Activity

Add Coop Page (Close #55) #69

Merged
b72zhou merged 37 commits from b72zhou-coop-page into main 2022-12-05 09:31:52 -05:00
Conversation 0 Commits 37 Files Changed 2 +899
b72zhou commented 2022-10-19 15:28:01 -04:00
Contributor
Copy Link

Closes #55

https://b72zhou-coop-page-csc-class-profile-staging-snedadah.k8s.csclub.cloud/coop/

Closes #55 https://b72zhou-coop-page-csc-class-profile-staging-snedadah.k8s.csclub.cloud/coop/
b72zhou added 10 commits 2022-10-19 15:28:02 -04:00
continuous-integration/drone/push Build is passing Details
ce87bbe3cd add coop
continuous-integration/drone/push Build is passing Details
38e8161f1a add: title
b72zhou added 1 commit 2022-11-08 22:22:39 -05:00
continuous-integration/drone/push Build is passing Details
4702e87dba :feat: add c7ii graph
b72zhou added 1 commit 2022-11-08 23:23:54 -05:00
continuous-integration/drone/push Build is passing Details
6a1d48b693 :feat: add c7iii graph
b72zhou added 1 commit 2022-11-08 23:54:30 -05:00
continuous-integration/drone/push Build is passing Details
2967702d25 :feat: add c7iv graph
b72zhou added 1 commit 2022-11-09 00:13:26 -05:00
continuous-integration/drone/push Build is passing Details
bd1dd177ca :feat: add c7v graph
b72zhou added 1 commit 2022-11-09 00:33:56 -05:00
continuous-integration/drone/push Build is passing Details
4558811ff9 :feat: add c7vi graph
b72zhou added 1 commit 2022-11-09 01:13:27 -05:00
continuous-integration/drone/push Build is passing Details
963fd050fd :feat: add c7vii graph
b72zhou added 1 commit 2022-11-09 10:31:35 -05:00
continuous-integration/drone/push Build is passing Details
2caa01c9da :feat: add c7viii graph
b72zhou changed title from WIP: b72zhou-coop-page to b72zhou-coop-page 2022-11-09 21:02:00 -05:00
b72zhou added 1 commit 2022-11-23 12:31:05 -05:00
continuous-integration/drone/push Build is failing Details
02520352f8 :feat: c7i
e26chiu requested changes 2022-11-23 16:08:07 -05:00
e26chiu left a comment
Contributor
Copy Link

Actually, when writing feedback, I just realized that you may not have updated your branch yet. Anyways, these are few commments that we can revise on after the branch has been updated!

Actually, when writing feedback, I just realized that you may not have updated your branch yet. Anyways, these are few commments that we can revise on after the branch has been updated!
pages/coop.tsx Outdated
@ -0,0 +42,4 @@
return (
<div className={styles.page}>
<h1 className={styles.title}>Co-op</h1>
e26chiu commented 2022-11-23 15:53:04 -05:00
Contributor
Copy Link

We can replace this part with the SectionHeader component that I added! You can check how to add it here: 1c0191facc/pages/demographics.tsx (L43)

We can replace this part with the `SectionHeader` component that I added! You can check how to add it here: https://git.csclub.uwaterloo.ca/www/cs-2022-class-profile/src/commit/1c0191facc6fb5931c4cb45fd54d999a8835bf4e/pages/demographics.tsx#L43
b72zhou marked this conversation as resolved
pages/coop.tsx Outdated
@ -0,0 +53,4 @@
align="left"
>
<div style={{ padding: "5px" }}>
<PieChart data={c1Data} width={400} labelWidth={90} />
e26chiu commented 2022-11-23 16:05:28 -05:00
Contributor
Copy Link

You can update all the PieChart props with default ones from the util file: 1c0191facc/pages/demographics.tsx (L53)

You can update all the PieChart props with default ones from the util file: https://git.csclub.uwaterloo.ca/www/cs-2022-class-profile/src/commit/1c0191facc6fb5931c4cb45fd54d999a8835bf4e/pages/demographics.tsx#L53
b72zhou marked this conversation as resolved
pages/coop.tsx Outdated
@ -0,0 +64,4 @@
align="center"
>
<WordCloud
data={c2Data.map((word) => ({
e26chiu commented 2022-11-23 15:57:26 -05:00
Contributor
Copy Link

I think it would be nice if c2Data is formatted in { text:string, value:number } already just so we can save a few lines of code here.

I think it would be nice if `c2Data` is formatted in `{ text:string, value:number }` already just so we can save a few lines of code here.
b72zhou marked this conversation as resolved
pages/coop.tsx Outdated
@ -0,0 +93,4 @@
noBackground
>
<WordCloud
data={c4Data.map((word) => ({
e26chiu commented 2022-11-23 15:58:02 -05:00
Contributor
Copy Link

The same can be said here about c4Data (reformatting it)

The same can be said here about c4Data (reformatting it)
b72zhou marked this conversation as resolved
pages/coop.tsx Outdated
@ -0,0 +299,4 @@
</ComponentWrapper>
<BottomNav
leftPageLink="/"
e26chiu commented 2022-11-23 16:07:16 -05:00
Contributor
Copy Link

BottomNav component should be updated: 1c0191facc/pages/demographics.tsx (L160)

BottomNav component should be updated: https://git.csclub.uwaterloo.ca/www/cs-2022-class-profile/src/commit/1c0191facc6fb5931c4cb45fd54d999a8835bf4e/pages/demographics.tsx#L160
b72zhou marked this conversation as resolved
pages/samplePage.module.css Outdated
@ -4,1 +4,4 @@
justify-content: center;
}
.title {
e26chiu commented 2022-11-23 15:58:40 -05:00
Contributor
Copy Link

We can remove this code since this part is already included in the SectionHeader component.

We can remove this code since this part is already included in the `SectionHeader` component.
b72zhou marked this conversation as resolved
b72zhou added 1 commit 2022-11-30 09:58:38 -05:00
b72zhou added 1 commit 2022-11-30 11:10:49 -05:00
continuous-integration/drone/push Build is failing Details
fce366c569 :refactor: standard
b72zhou added 3 commits 2022-11-30 12:16:49 -05:00
continuous-integration/drone/push Build is failing Details
0955b918ea :refactor: standard
b72zhou added 1 commit 2022-11-30 12:26:23 -05:00
continuous-integration/drone/push Build is passing Details
c8f6a97a59 :refactor: standard
b72zhou requested review from e26chiu 2022-11-30 12:26:25 -05:00
b72zhou changed title from b72zhou-coop-page to Add Coop Page 2022-11-30 12:26:37 -05:00
b72zhou changed title from Add Coop Page to Add Coop Page (Close #55) 2022-11-30 16:09:23 -05:00
b72zhou added 1 commit 2022-11-30 22:05:06 -05:00
continuous-integration/drone/push Build is failing Details
c7faf1c12c Merge branch 'main' into b72zhou-coop-page
b72zhou added 4 commits 2022-11-30 22:38:46 -05:00
e26chiu added 5 commits 2022-12-04 19:12:31 -05:00
e26chiu approved these changes 2022-12-04 19:15:02 -05:00
e26chiu left a comment
Contributor
Copy Link

@b72zhou Nice work on integrating everything and keeping this page up with changes! I edited the blurbs, moved few questions around, and integrated the latest changes! Everything else LGTM! 😁🚀

@b72zhou Nice work on integrating everything and keeping this page up with changes! I edited the blurbs, moved few questions around, and integrated the latest changes! Everything else LGTM! 😁🚀
❤️ 1
e26chiu added 2 commits 2022-12-04 19:33:59 -05:00
continuous-integration/drone/push Build is passing Details
4c10454c95 Fix merge conflicts
e26chiu added 1 commit 2022-12-04 21:44:25 -05:00
continuous-integration/drone/push Build is passing Details
f3359ef89d Edit blurb
b72zhou merged commit 15191bb89e into main 2022-12-05 09:31:52 -05:00
b72zhou deleted branch b72zhou-coop-page 2022-12-05 09:31:52 -05:00
Sign in to join this conversation.
Reviewers
No reviewers
e26chiu
Labels
Clear labels   
Bug

   
Component

   
Config

   
Good First Issue

   
Low-Priority

   
Page
No Label
Bug
Component
Config
Good First Issue
Low-Priority
Page
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: www/cs-2022-class-profile#69
No description provided.
Delete Branch "b72zhou-coop-page"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?