www
/
cs-2022-class-profile
16
0
Fork 0
Code Issues 11 Pull Requests 1 Projects Releases Wiki Activity

Made bottom arrows optional and refactored routes (Closes #72) #76

Merged
snedadah merged 5 commits from opt-arrows into main 2022-11-05 14:06:25 -04:00
Conversation 0 Commits 5 Files Changed 8 +100 -62
snedadah commented 2022-11-04 03:48:49 -04:00
Owner
Copy Link

https://opt-arrows-csc-class-profile-staging-snedadah.k8s.csclub.cloud/samplePage/
(no visual changes in sample page though)

Made it so you can type rightPage={pageRoutes.demographics} and you get autocomplete on the route name.

https://opt-arrows-csc-class-profile-staging-snedadah.k8s.csclub.cloud/samplePage/ (no visual changes in sample page though) Made it so you can type rightPage={pageRoutes.demographics} and you get autocomplete on the route name.
snedadah added 1 commit 2022-11-04 03:48:50 -04:00
continuous-integration/drone/push Build is passing Details
2796aad456 Made arrows optional and refactored routes
snedadah requested review from e26chiu 2022-11-04 03:57:01 -04:00
snedadah added 1 commit 2022-11-05 01:51:47 -04:00
continuous-integration/drone/push Build is passing Details
3b960baf72 Made arrows not scroll page on mobile
snedadah reviewed 2022-11-05 02:18:54 -04:00
components/BottomNav.module.css
@ -94,3 +94,3 @@
.arrow {
width: calc(200rem / 16);
width: 100%;
snedadah commented 2022-11-05 02:18:54 -04:00
Author
Owner
Copy Link

fixes a horizontal scrolling issue on mobile

fixes a horizontal scrolling issue on mobile
e26chiu approved these changes 2022-11-05 09:43:34 -04:00
e26chiu left a comment
Contributor
Copy Link

Hey @snedadah ! Thank you for picking up this work! The code looks super clean!💯 Links work as expected. I tested with both one link on either side and it looks good. I like the PageRoutes thing you introduced!

Small Nitpick on my side for how it looks on mobile when the 2 arrows are defined (this may have been a problem before and I don't know if you intend to fix this issue within this PR): I see that there is a breakpoint at width=769px where the arrows and the labels get smaller so it fits within the width of the page. Between width 769px and 848px, the right arrow is overflowing to the right causing the page to extend (you can horizontally scroll the page to the right). For context, I'm seeing this problem on Firefox. We can create a separate PR to address this issue though.

image

Hey @snedadah ! Thank you for picking up this work! The code looks super clean!💯 Links work as expected. I tested with both one link on either side and it looks good. I like the PageRoutes thing you introduced! Small Nitpick on my side for how it looks on mobile when the 2 arrows are defined (this may have been a problem before and I don't know if you intend to fix this issue within this PR): I see that there is a breakpoint at width=769px where the arrows and the labels get smaller so it fits within the width of the page. Between width 769px and 848px, the right arrow is overflowing to the right causing the page to extend (you can horizontally scroll the page to the right). For context, I'm seeing this problem on Firefox. We can create a separate PR to address this issue though. ![image](/attachments/fdcddbcc-a232-4e26-abb6-30a471b32333)
image.png
8.5 KiB
e26chiu changed title from Made bottom arrows optional and refactored routes to Made bottom arrows optional and refactored routes (Closes #72) 2022-11-05 09:44:16 -04:00
snedadah added 2 commits 2022-11-05 12:28:22 -04:00
continuous-integration/drone/push Build is passing Details
4fd374ce39 Changed breakpoints to fix scrolling on mobile
snedadah added 1 commit 2022-11-05 12:43:56 -04:00
continuous-integration/drone/push Build is passing Details
b1055a6652 Fixed center wrapper broken on mobile
snedadah merged commit 80530c1c1a into main 2022-11-05 14:06:25 -04:00
snedadah deleted branch opt-arrows 2022-11-05 14:06:25 -04:00
Sign in to join this conversation.
Reviewers
No reviewers
e26chiu
Labels
Clear labels   
Bug

   
Component

   
Config

   
Good First Issue

   
Low-Priority

   
Page
No Label
Bug
Component
Config
Good First Issue
Low-Priority
Page
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: www/cs-2022-class-profile#76
No description provided.
Delete Branch "opt-arrows"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?