Link #19

New Issue

2021-04-25T16:17:34-04:00

a3thakra commented

2021-04-25 16:17:34 -04:00

(Migrated from git.uwaterloo.ca)

No description provided.

a3thakra commented

2021-04-25 17:46:00 -04:00

(Migrated from git.uwaterloo.ca)

added 1 design

added [1 design](/csc/website/-/issues/19/designs?version=142)

b38peng commented

2021-04-27 15:33:00 -04:00

(Migrated from git.uwaterloo.ca)

assigned to @b38peng

a3thakra commented

2021-04-27 18:40:01 -04:00

(Migrated from git.uwaterloo.ca)

unassigned @b38peng

c29wan commented

2021-05-18 10:08:46 -04:00

(Migrated from git.uwaterloo.ca)

assigned to @c29wan

b38peng commented

2021-05-28 23:48:29 -04:00

(Migrated from git.uwaterloo.ca)

changed the description

a3thakra commented

2021-05-29 20:50:03 -04:00

(Migrated from git.uwaterloo.ca)

it's good practice to leave a line between css rules targeting different selectors :)

a3thakra commented

2021-05-29 20:58:14 -04:00

(Migrated from git.uwaterloo.ca)

You should instead change the options for creating the time string. You can add timeZoneName: 'short' to the options for it to output time zone.

You should instead change the options for creating the time string. You can add `timeZoneName: 'short'` to the options for it to output time zone.

a3thakra commented

2021-05-29 20:59:03 -04:00

(Migrated from git.uwaterloo.ca)

  const time = props.date.toLocaleTimeString("en-US", {
    hour: "numeric",
    minute: "numeric",
    timeZoneName: "short",
  });

```suggestion:-3+0 const time = props.date.toLocaleTimeString("en-US", { hour: "numeric", minute: "numeric", timeZoneName: "short", }); ```

a3thakra commented

2021-05-29 21:00:09 -04:00

(Migrated from git.uwaterloo.ca)

      {location}

does this work?

```suggestion:-0+0 {location} ``` does this work?

a3thakra commented

2021-05-29 21:00:50 -04:00

(Migrated from git.uwaterloo.ca)

just wrapping the date with the time tag should be enough :)

a3thakra commented

2021-05-29 21:02:27 -04:00

(Migrated from git.uwaterloo.ca)

you might need to wrap it with a span tho (and add the setting className to it) to make it behave correctly on mobiles.

b38peng commented

2021-06-01 18:44:41 -04:00

(Migrated from git.uwaterloo.ca)

You mean like <time>{date}</time>? or {date}?

You mean like `<time>{date}</time>`? or `{date}`?

c29wan commented

2021-06-02 21:54:02 -04:00

(Migrated from git.uwaterloo.ca)

mentioned in merge request !20

a3thakra commented

2021-06-03 14:15:54 -04:00

(Migrated from git.uwaterloo.ca)

You can wrap the {date} with <time>, and {time} with 

You can wrap the `{date}` with `<time>`, and `{time}` with ``

a3thakra commented

2021-06-03 14:17:10 -04:00

(Migrated from git.uwaterloo.ca)

Sorry I wasn't more clear earlier 🙈

b38peng commented

2021-06-03 20:03:54 -04:00

(Migrated from git.uwaterloo.ca)

changed this line in version 2 of the diff

changed this line in [version 2 of the diff](/csc/website/-/merge_requests/19/diffs?diff_id=58008&start_sha=4e6ce7a97de3cf51107c2fce8158a1c9e9d0ce6a#20699e63c737a29c439db64f829e0a859790abd3_31_27)

b38peng commented

2021-06-03 20:03:54 -04:00

(Migrated from git.uwaterloo.ca)

changed this line in version 2 of the diff

changed this line in [version 2 of the diff](/csc/website/-/merge_requests/19/diffs?diff_id=58008&start_sha=4e6ce7a97de3cf51107c2fce8158a1c9e9d0ce6a#20699e63c737a29c439db64f829e0a859790abd3_34_30)

b38peng commented

2021-06-03 20:03:55 -04:00

(Migrated from git.uwaterloo.ca)

added 3 commits

13c20dd8 - 1 commit from branch main
6d6e6d83 - Merge branch 'main' of https://git.uwaterloo.ca/csc/website into feat/mobile-event-description-card
c9cf662f - displays local timezone

Compare with previous version

added 3 commits <ul><li>13c20dd8 - 1 commit from branch <code>main</code></li><li>6d6e6d83 - Merge branch 'main' of https://git.uwaterloo.ca/csc/website into feat/mobile-event-description-card</li><li>c9cf662f - displays local timezone</li></ul> [Compare with previous version](/csc/website/-/merge_requests/19/diffs?diff_id=58008&start_sha=4e6ce7a97de3cf51107c2fce8158a1c9e9d0ce6a)

b38peng commented

2021-06-03 20:04:10 -04:00

(Migrated from git.uwaterloo.ca)

resolved all threads

b38peng commented

2021-06-03 20:07:42 -04:00

(Migrated from git.uwaterloo.ca)

added 1 commit

d1960c2f - converts to local timezone

Compare with previous version

added 1 commit <ul><li>d1960c2f - converts to local timezone</li></ul> [Compare with previous version](/csc/website/-/merge_requests/19/diffs?diff_id=58012&start_sha=c9cf662fac21c107ce8c67c3687e6681e3e42872)

b38peng commented

2021-06-03 20:11:35 -04:00

(Migrated from git.uwaterloo.ca)

added 1 commit

42096c2a - revert changes

Compare with previous version

added 1 commit <ul><li>42096c2a - revert changes</li></ul> [Compare with previous version](/csc/website/-/merge_requests/19/diffs?diff_id=58013&start_sha=d1960c2ffeb6b7cda773235cc272b4caa4b8fafd)

a3thakra commented

2021-06-06 19:58:13 -04:00

(Migrated from git.uwaterloo.ca)

It's preferred to not specify units with line-height. https://developer.mozilla.org/en-US/docs/Web/CSS/line-height#values

    line-height: calc(21 / 16);

It's preferred to not specify units with line-height. https://developer.mozilla.org/en-US/docs/Web/CSS/line-height#values ```suggestion:-0+0 line-height: calc(21 / 16); ```

b38peng commented

2021-06-07 19:08:32 -04:00

(Migrated from git.uwaterloo.ca)

resolved all threads

b38peng commented

2021-06-07 19:08:33 -04:00

(Migrated from git.uwaterloo.ca)

changed this line in version 5 of the diff

changed this line in [version 5 of the diff](/csc/website/-/merge_requests/19/diffs?diff_id=58580&start_sha=42096c2ad7b700b80259cb83e733f84af3afc533#1279fe27f7ebcc19c2d026bb396a73f23206b2df_71_71)

b38peng commented

2021-06-07 19:08:33 -04:00

(Migrated from git.uwaterloo.ca)

added 1 commit

e253283d - Apply 1 suggestion(s) to 1 file(s)

Compare with previous version

added 1 commit <ul><li>e253283d - Apply 1 suggestion(s) to 1 file(s)</li></ul> [Compare with previous version](/csc/website/-/merge_requests/19/diffs?diff_id=58580&start_sha=42096c2ad7b700b80259cb83e733f84af3afc533)

b38peng commented

2021-06-07 19:12:33 -04:00

(Migrated from git.uwaterloo.ca)

added 2 commits

04c4efde - remove line height units
25ec4c4c - Merge branch 'feat/mobile-event-description-card' of...

Compare with previous version

added 2 commits <ul><li>04c4efde - remove line height units</li><li>25ec4c4c - Merge branch 'feat/mobile-event-description-card' of...</li></ul> [Compare with previous version](/csc/website/-/merge_requests/19/diffs?diff_id=58584&start_sha=e253283d5ce16cfe54ae19a4a7287e532cacdc44)

a3thakra commented

2021-06-09 06:56:21 -04:00

(Migrated from git.uwaterloo.ca)

line-height tells the browser, well, the height of the line.

If it is a value with a unit such as rems or pixels, the browser can just set the height of that line to that value.

If it is a unitless value, then the browser needs to convert it into some unit. line-heights are multiplied with the element's font-size to get a px / rem value.

So, to remove units for a line-height of 21px here, we need to divide by 14, and not 16. :) Took me a second to realize what was going on! :)

`line-height` tells the browser, well, the height of the line. If it is a value with a unit such as rems or pixels, the browser can just set the height of that line to that value. If it is a unitless value, then the browser needs to convert it into some unit. line-heights are multiplied with the element's font-size to get a px / rem value. So, to remove units for a line-height of 21px here, we need to divide by 14, and not 16. :) Took me a second to realize what was going on! :)

a3thakra commented

2021-06-09 07:08:01 -04:00

(Migrated from git.uwaterloo.ca)

changed this line in version 7 of the diff

changed this line in [version 7 of the diff](/csc/website/-/merge_requests/19/diffs?diff_id=58878&start_sha=25ec4c4cb24051f419dc0794a985048dc2b88af1#1279fe27f7ebcc19c2d026bb396a73f23206b2df_71_71)

a3thakra commented

2021-06-09 07:08:01 -04:00

(Migrated from git.uwaterloo.ca)

added 1 commit

91100ff7 - Fix line-heights

Compare with previous version

added 1 commit <ul><li>91100ff7 - Fix line-heights</li></ul> [Compare with previous version](/csc/website/-/merge_requests/19/diffs?diff_id=58878&start_sha=25ec4c4cb24051f419dc0794a985048dc2b88af1)

a3thakra commented

2021-06-09 07:08:23 -04:00

(Migrated from git.uwaterloo.ca)

Excellent! 💯

Excellent! :100:

a3thakra commented

2021-06-09 07:09:59 -04:00

(Migrated from git.uwaterloo.ca)

approved this merge request

a3thakra commented

2021-06-09 07:10:24 -04:00

(Migrated from git.uwaterloo.ca)

added 13 commits

91100ff7...2b733ade - 6 commits from branch main
b2a89ce7 - mobile fixes
ac927790 - mobile styling
43a7d109 - displays local timezone
4baeb353 - converts to local timezone
c321cc15 - revert changes
41b24338 - remove line height units
a99ec843 - Fix line-heights

Compare with previous version

added 13 commits <ul><li>91100ff7...2b733ade - 6 commits from branch <code>main</code></li><li>b2a89ce7 - mobile fixes</li><li>ac927790 - mobile styling</li><li>43a7d109 - displays local timezone</li><li>4baeb353 - converts to local timezone</li><li>c321cc15 - revert changes</li><li>41b24338 - remove line height units</li><li>a99ec843 - Fix line-heights</li></ul> [Compare with previous version](/csc/website/-/merge_requests/19/diffs?diff_id=58880&start_sha=91100ff7d38eb6576eac7830543f768ee8059f37)

Sign in to join this conversation.