Playground #21

Closed
opened 2021-04-25 16:29:19 -04:00 by a3thakra · 23 comments
a3thakra commented 2021-04-25 16:29:19 -04:00 (Migrated from git.uwaterloo.ca)
No description provided.
a3thakra commented 2021-04-26 19:25:01 -04:00 (Migrated from git.uwaterloo.ca)

Fixed in 91ee5e5d95

Fixed in 91ee5e5d95223f00128a961df46ac5fa2dcc59bf
l42luo commented 2021-06-02 23:05:56 -04:00 (Migrated from git.uwaterloo.ca)

changed the description

changed the description
n3parikh commented 2021-06-06 20:02:10 -04:00 (Migrated from git.uwaterloo.ca)

Can this be removed?

Can this be removed?
n3parikh commented 2021-06-06 20:02:10 -04:00 (Migrated from git.uwaterloo.ca)

color is unused?

`color` is unused?
n3parikh commented 2021-06-06 20:02:10 -04:00 (Migrated from git.uwaterloo.ca)

Can we instead use the svg files you've created, so that the code the code is a little cleaner?

Can we instead use the svg files you've created, so that the code the code is a little cleaner?
l42luo commented 2021-06-07 00:16:26 -04:00 (Migrated from git.uwaterloo.ca)

added 1 commit

  • 83fc68cc - added ability to make Links white or gradient

Compare with previous version

added 1 commit <ul><li>83fc68cc - added ability to make Links white or gradient</li></ul> [Compare with previous version](/csc/website/-/merge_requests/21/diffs?diff_id=58415&start_sha=7079263c3638973af4d5d09b993abc028a7c6f3b)
l42luo commented 2021-06-07 17:56:49 -04:00 (Migrated from git.uwaterloo.ca)

changed this line in version 3 of the diff

changed this line in [version 3 of the diff](/csc/website/-/merge_requests/21/diffs?diff_id=58550&start_sha=83fc68ccd6d5c51df68254b730d7cc64899e2b49#9aa585bda7c4f2c98e7806316ac9b1afc61182fe_27_27)
l42luo commented 2021-06-07 17:56:49 -04:00 (Migrated from git.uwaterloo.ca)

added 1 commit

Compare with previous version

added 1 commit <ul><li>9f85fc98 - Removed comment</li></ul> [Compare with previous version](/csc/website/-/merge_requests/21/diffs?diff_id=58550&start_sha=83fc68ccd6d5c51df68254b730d7cc64899e2b49)
l42luo commented 2021-06-07 18:13:39 -04:00 (Migrated from git.uwaterloo.ca)

added 1 commit

Compare with previous version

added 1 commit <ul><li>148b938e - Removed svgs from logos file</li></ul> [Compare with previous version](/csc/website/-/merge_requests/21/diffs?diff_id=58557&start_sha=9f85fc98a528c2288361e5f0ea5e59cd34cfec7a)
a3thakra commented 2021-06-07 22:20:18 -04:00 (Migrated from git.uwaterloo.ca)

We're dynamically changing colours for these, which is why we're inlining them. (Line 70) If there's a better way to achieve the same thing without inlining them, we should do that :)

We're dynamically changing colours for these, which is why we're inlining them. (Line 70) If there's a better way to achieve the same thing without inlining them, we should do that :)
a3thakra commented 2021-06-12 21:09:57 -04:00 (Migrated from git.uwaterloo.ca)
  • Capitalize these, get rid of the Svg suffix
  • export them so we can use them in other places
  • move iconList above these
- Capitalize these, get rid of the `Svg` suffix - `export` them so we can use them in other places - move `iconList` above these
a3thakra commented 2021-06-12 21:10:42 -04:00 (Migrated from git.uwaterloo.ca)

Don't render footer in the playground, instead render it in _app.tsx

Don't render footer in the playground, instead render it in `_app.tsx`
a3thakra commented 2021-06-12 21:11:19 -04:00 (Migrated from git.uwaterloo.ca)

Remove the .pngs

Remove the `.png`s
a3thakra commented 2021-06-12 21:11:55 -04:00 (Migrated from git.uwaterloo.ca)

Make sure that you're using npm v7+ and remove changes to package.json and package-lock.json

Make sure that you're using npm v7+ and remove changes to package.json and package-lock.json
a3thakra commented 2021-06-13 15:59:49 -04:00 (Migrated from git.uwaterloo.ca)

changed this line in version 5 of the diff

changed this line in [version 5 of the diff](/csc/website/-/merge_requests/21/diffs?diff_id=59672&start_sha=148b938ea7a4d1e143848caa614597201dd4711e#9aa585bda7c4f2c98e7806316ac9b1afc61182fe_50_0)
a3thakra commented 2021-06-13 15:59:49 -04:00 (Migrated from git.uwaterloo.ca)

changed this line in version 5 of the diff

changed this line in [version 5 of the diff](/csc/website/-/merge_requests/21/diffs?diff_id=59672&start_sha=148b938ea7a4d1e143848caa614597201dd4711e#9aa585bda7c4f2c98e7806316ac9b1afc61182fe_52_0)
a3thakra commented 2021-06-13 15:59:49 -04:00 (Migrated from git.uwaterloo.ca)

changed this line in version 5 of the diff

changed this line in [version 5 of the diff](/csc/website/-/merge_requests/21/diffs?diff_id=59672&start_sha=148b938ea7a4d1e143848caa614597201dd4711e#9aa585bda7c4f2c98e7806316ac9b1afc61182fe_27_0)
a3thakra commented 2021-06-13 15:59:49 -04:00 (Migrated from git.uwaterloo.ca)

changed this line in version 5 of the diff

changed this line in [version 5 of the diff](/csc/website/-/merge_requests/21/diffs?diff_id=59672&start_sha=148b938ea7a4d1e143848caa614597201dd4711e#52702b5631fd7b0022e0a2179e9b14b1fa4dd61b_157_156)
a3thakra commented 2021-06-13 15:59:49 -04:00 (Migrated from git.uwaterloo.ca)

added 2 commits

  • 96e21aa2 - Remove footer from playground and use it in app.tsx
  • 15b81e2a - Export individual links + rename to SocialLinks

Compare with previous version

added 2 commits <ul><li>96e21aa2 - Remove footer from playground and use it in app.tsx</li><li>15b81e2a - Export individual links + rename to SocialLinks</li></ul> [Compare with previous version](/csc/website/-/merge_requests/21/diffs?diff_id=59672&start_sha=148b938ea7a4d1e143848caa614597201dd4711e)
n3parikh commented 2021-06-13 16:28:31 -04:00 (Migrated from git.uwaterloo.ca)

added 13 commits

  • 15b81e2a...078276ef - 10 commits from branch main
  • 8c5bd770 - remove pngs
  • 5a9733c9 - revert package.json
  • 4125a7dc - Merge branch 'main' into feat/footer

Compare with previous version

added 13 commits <ul><li>15b81e2a...078276ef - 10 commits from branch <code>main</code></li><li>8c5bd770 - remove pngs</li><li>5a9733c9 - revert package.json</li><li>4125a7dc - Merge branch &#39;main&#39; into feat/footer</li></ul> [Compare with previous version](/csc/website/-/merge_requests/21/diffs?diff_id=59678&start_sha=15b81e2a9efd99b2da48bcd3d701a4e26e910865)
a3thakra commented 2021-06-13 19:36:23 -04:00 (Migrated from git.uwaterloo.ca)

added 1 commit

Compare with previous version

added 1 commit <ul><li>0051d08e - Fix some CSS</li></ul> [Compare with previous version](/csc/website/-/merge_requests/21/diffs?diff_id=59724&start_sha=4125a7dc8fb705f21f4160c50b59638a499bd751)
a3thakra commented 2021-06-13 19:52:02 -04:00 (Migrated from git.uwaterloo.ca)

added 2 commits

Compare with previous version

added 2 commits <ul><li>5646c9b2 - Use rems</li><li>05bc486f - Remove Footer reference from playground.mdx</li></ul> [Compare with previous version](/csc/website/-/merge_requests/21/diffs?diff_id=59726&start_sha=0051d08ec26acf5bf8826034fbcac70bed87a794)
a3thakra commented 2021-06-13 19:53:18 -04:00 (Migrated from git.uwaterloo.ca)

enabled an automatic merge when the pipeline for 05bc486fc6 succeeds

enabled an automatic merge when the pipeline for 05bc486fc6084f474030408e579d96550359cdec succeeds
Sign in to join this conversation.
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: www/www-new#21
No description provided.