Use postcss-calc and convert all the weird rem values to a better format #28

Closed
opened 2021-05-21 03:21:10 -04:00 by a3thakra · 8 comments
a3thakra commented 2021-05-21 03:21:10 -04:00 (Migrated from git.uwaterloo.ca)

So something like calc(24rem / 16) would be compiled to 1.5rem during build time. But it is still readable while we're working on the codebase.

So something like `calc(24rem / 16)` would be compiled to `1.5rem` during build time. But it is still readable while we're working on the codebase.
a3thakra commented 2021-05-21 03:21:10 -04:00 (Migrated from git.uwaterloo.ca)

changed due date to May 24, 2021

changed due date to May 24, 2021
a3thakra commented 2021-05-21 04:06:08 -04:00 (Migrated from git.uwaterloo.ca)

changed due date to May 23, 2021

changed due date to May 23, 2021
a3thakra commented 2021-05-24 14:53:33 -04:00 (Migrated from git.uwaterloo.ca)

mentioned in merge request !15

mentioned in merge request !15
c29wan commented 2021-06-24 15:40:25 -04:00 (Migrated from git.uwaterloo.ca)

added 3 commits

  • 89ca342a...48056ca8 - 2 commits from branch main
  • 6cb1f570 - Merge branch 'main' into feat/tech-talk-card

Compare with previous version

added 3 commits <ul><li>89ca342a...48056ca8 - 2 commits from branch <code>main</code></li><li>6cb1f570 - Merge branch &#39;main&#39; into feat/tech-talk-card</li></ul> [Compare with previous version](/csc/website/-/merge_requests/28/diffs?diff_id=62006&start_sha=89ca342a7f687c303ed6dde0d83096a680adec1c)
c29wan commented 2021-06-24 19:01:20 -04:00 (Migrated from git.uwaterloo.ca)

added 1 commit

  • d419d9ee - create mini tech card, edit tech card description

Compare with previous version

added 1 commit <ul><li>d419d9ee - create mini tech card, edit tech card description</li></ul> [Compare with previous version](/csc/website/-/merge_requests/28/diffs?diff_id=62087&start_sha=6cb1f57002ae6de84b8676b50053d3e0fe5dc812)
n3parikh commented 2021-06-26 23:10:26 -04:00 (Migrated from git.uwaterloo.ca)

MiniTechTalkCard.module.css has no spacer class.

`MiniTechTalkCard.module.css` has no `spacer` class.
n3parikh commented 2021-06-26 23:10:27 -04:00 (Migrated from git.uwaterloo.ca)

Can you add a few more items, to show the alternating behavior?

Can you add a few more items, to show the alternating behavior?
n3parikh commented 2021-06-26 23:12:12 -04:00 (Migrated from git.uwaterloo.ca)
Can you use `var(--teal-2-20)` here? See: https://git.uwaterloo.ca/csc/website/-/merge_requests/29/diffs#7e94d1f8704bfe79083db58b9822eb765511e03a_9_7
Sign in to join this conversation.
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: www/www-new#28
No description provided.