Mobile EventDescriptionCard #32

Closed
opened 2021-05-28 23:01:56 -04:00 by b38peng · 13 comments
b38peng commented 2021-05-28 23:01:56 -04:00 (Migrated from git.uwaterloo.ca)

Add responsiveness to the EventDescriptionCard component

image

Add responsiveness to the EventDescriptionCard component ![image](/uploads/a494ad9d5641202bd4c4c671aa064079/image.png)
b38peng commented 2021-05-28 23:02:55 -04:00 (Migrated from git.uwaterloo.ca)

changed the description

changed the description
b38peng commented 2021-05-28 23:47:17 -04:00 (Migrated from git.uwaterloo.ca)

mentioned in merge request !19

mentioned in merge request !19
a258wang commented 2021-06-24 17:39:37 -04:00 (Migrated from git.uwaterloo.ca)

added 1 commit

Compare with previous version

added 1 commit <ul><li>39b680e1 - Fix whitespace</li></ul> [Compare with previous version](/csc/website/-/merge_requests/32/diffs?diff_id=62058&start_sha=4ec4fdb09706dc929d12e2754fb5d7a15276d09b)
a258wang commented 2021-06-24 17:43:16 -04:00 (Migrated from git.uwaterloo.ca)

changed the description

changed the description
a258wang commented 2021-06-25 11:36:49 -04:00 (Migrated from git.uwaterloo.ca)

added 1 commit

  • d549bce3 - Fix dropdown icon orientation

Compare with previous version

added 1 commit <ul><li>d549bce3 - Fix dropdown icon orientation</li></ul> [Compare with previous version](/csc/website/-/merge_requests/32/diffs?diff_id=62223&start_sha=39b680e101292da5b9119b1cc886bfae34f69ada)
n3parikh commented 2021-06-26 23:36:37 -04:00 (Migrated from git.uwaterloo.ca)

This line raises a lint warning. See: https://git.uwaterloo.ca/csc/website/-/jobs/51078#L30

This line raises a lint warning. See: https://git.uwaterloo.ca/csc/website/-/jobs/51078#L30
n3parikh commented 2021-06-26 23:36:37 -04:00 (Migrated from git.uwaterloo.ca)
This line raises 2 lint warnings. See: - https://git.uwaterloo.ca/csc/website/-/jobs/51078#L32 - https://git.uwaterloo.ca/csc/website/-/jobs/51078#L36
n3parikh commented 2021-06-26 23:36:37 -04:00 (Migrated from git.uwaterloo.ca)

This won't work when we try to build/export the site, since it's not really possible to output static HTML that will redirect.

Also, why do we need this?

This won't work when we try to build/export the site, since it's not really possible to output static HTML that will redirect. Also, why do we need this?
a3thakra commented 2021-06-27 18:33:35 -04:00 (Migrated from git.uwaterloo.ca)

you can use the Record<string, unknown> type instead of using {}

you can use the `Record<string, unknown>` type instead of using `{}`
a3thakra commented 2021-06-27 19:49:46 -04:00 (Migrated from git.uwaterloo.ca)

ah right, didn't think of redirects not working :face_palm:

ah right, didn't think of redirects not working :face_palm:
a3thakra commented 2021-06-27 19:50:49 -04:00 (Migrated from git.uwaterloo.ca)

I asked Amy to do redirects because it makes recognizing child routes way easier

I asked Amy to do redirects because it makes recognizing child routes way easier
a3thakra commented 2021-06-27 19:51:10 -04:00 (Migrated from git.uwaterloo.ca)

oh well ... we should probably do something else

oh well ... we should probably do something else
a3thakra commented 2021-06-27 20:09:09 -04:00 (Migrated from git.uwaterloo.ca)
https://css-tricks.com/snippets/html/meta-refresh/ and https://nextjs.org/docs/api-reference/next/head if we want to redirect
Sign in to join this conversation.
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: www/www-new#32
No description provided.