Update Beihao's name and photo on team page #377

b72zhou · 2022-01-11T00:39:30-05:00

b72zhou commented

2022-01-11 00:39:30 -05:00

No description provided.

b72zhou added 1 commit 2022-01-11 00:39:31 -05:00

continuous-integration/drone/push Build is passing Details

de0dee5bdb Update Beihao's name and photo on team page

b72zhou requested review from a258wang 2022-01-11 00:42:57 -05:00

b72zhou requested review from n3parikh 2022-01-11 00:44:00 -05:00

b72zhou requested review from j285he 2022-01-11 00:44:00 -05:00

a258wang approved these changes 2022-01-11 01:13:42 -05:00

a258wang left a comment

Assuming that the PR is done, everything looks good to me! In the future, you only need to put WIP if you're not finished and don't want people to review it yet. But in this case, once you remove the WIP prefix from the PR title, you should be good to merge it! Awesome work Beihao! 😄

By the way, here's what the changes look like on staging: https://csclub.uwaterloo.ca/~a3thakra/csc/beihao-team-update/about/team/

Assuming that the PR is done, everything looks good to me! In the future, you only need to put WIP if you're not finished and don't want people to review it yet. But in this case, once you remove the WIP prefix from the PR title, you should be good to merge it! Awesome work Beihao! 😄 By the way, here's what the changes look like on staging: https://csclub.uwaterloo.ca/~a3thakra/csc/beihao-team-update/about/team/

j285he approved these changes 2022-01-11 18:29:55 -05:00

b72zhou changed title from ~~WIP: Update Beihao's name and photo on team page~~ to Update Beihao's name and photo on team page

2022-01-12 07:39:45 -05:00

b72zhou merged commit 4af820f150 into main

2022-01-12 07:43:10 -05:00

b72zhou deleted branch beihao-team-update

2022-01-12 07:43:10 -05:00

b72zhou referenced this issue from a commit

2022-01-12 07:43:10 -05:00

Update Beihao's name and photo on team page (#377)

Sign in to join this conversation.

No reviewers