www
/
www-new
12
3
Fork 5
Code Issues 58 Pull Requests 42 Projects Releases Wiki Activity

Separate Teams on Meet the Team page (Close #346) #404

Merged
b72zhou merged 4 commits from beihao-separate-teams into main 2022-03-09 10:03:28 -05:00
Conversation 3 Commits 4 Files Changed 10 +371 -256
b72zhou commented 2022-02-27 09:00:54 -05:00
Contributor
Copy Link
No description provided.
b72zhou added 2 commits 2022-02-27 09:00:56 -05:00
b72zhou commented 2022-02-27 09:04:11 -05:00
Author
Contributor
Copy Link

https://csclub.uwaterloo.ca/~a3thakra/csc/beihao-separate-teams/about/team/

Is this simply what we want for the page? Or do we need to redesign it and discuss with the design team?

https://csclub.uwaterloo.ca/~a3thakra/csc/beihao-separate-teams/about/team/ Is this simply what we want for the page? Or do we need to redesign it and discuss with the design team?
b72zhou requested review from a258wang 2022-02-27 09:04:34 -05:00
a258wang reviewed 2022-02-27 12:18:31 -05:00
pages/about/team.tsx Outdated
@ -16,7 +16,13 @@ import {
getMemberImagePath,
} from "@/lib/team";
import programmeData from "../../content/team/programme-committee.json";
a258wang commented 2022-02-27 12:18:31 -05:00
Owner
Copy Link

Did we delete the programme-committee.json file? If all the data will be stored in separate files for each team, then we probably won't need this file anymore.

Did we delete the `programme-committee.json` file? If all the data will be stored in separate files for each team, then we probably won't need this file anymore.
👍 1
b72zhou marked this conversation as resolved
a258wang reviewed 2022-02-27 12:19:05 -05:00
pages/about/team.tsx Outdated
@ -20,0 +22,4 @@
import externalData from "../../content/team/external-affairs-team.json";
import marketingData from "../../content/team/marketing-team.json";
import photographyData from "../../content/team/photography-team.json";
import RepsData from "../../content/team/representative-team.json";
a258wang commented 2022-02-27 12:19:05 -05:00
Owner
Copy Link

Nitpick: Let's name this repsData so the capitalization is consistent with everything else.

Nitpick: Let's name this `repsData` so the capitalization is consistent with everything else.
b72zhou marked this conversation as resolved
a258wang reviewed 2022-02-27 12:23:28 -05:00
pages/about/team.tsx Outdated
@ -83,0 +104,4 @@
<div id="design">
<h2 className={styles.subheading}>Design Team</h2>
<MembersList team={design} />
</div>
a258wang commented 2022-02-27 12:23:28 -05:00
Owner
Copy Link

Looking at all this repetition, I wonder if it might be better to create an array of objects, and then loop through the array in order to display the sections? For example:

const teams = [
  {
    name: "Design",
    members: design,
  },
  ...
];

...

teams.map((team) => {
  <div id={team.name}>
    ...
  </div>
});
Looking at all this repetition, I wonder if it might be better to create an array of objects, and then loop through the array in order to display the sections? For example: ```react const teams = [ { name: "Design", members: design, }, ... ]; ... teams.map((team) => { <div id={team.name}> ... </div> }); ```
👍 1
a258wang reviewed 2022-02-27 12:26:41 -05:00
pages/about/team.tsx Outdated
@ -56,0 +76,4 @@
<Link href="#external">External Affairs Team</Link>
<Link href="#marketing">Marketing Team</Link>
<Link href="#photography">Photography Team</Link>
<Link href="#reps">Representatives Team</Link>
a258wang commented 2022-02-27 12:26:41 -05:00
Owner
Copy Link

Maybe we can drop the "Team" from the labels/section headers and just have the team names be "Design", "Discord", "Events", etc.?

For Reps, maybe we could go with "Class Representatives"?

Maybe we can drop the "Team" from the labels/section headers and just have the team names be "Design", "Discord", "Events", etc.? For Reps, maybe we could go with "Class Representatives"?
👍 1
b72zhou marked this conversation as resolved
a258wang commented 2022-02-27 12:29:17 -05:00
Owner
Copy Link

https://csclub.uwaterloo.ca/~a3thakra/csc/beihao-separate-teams/about/team/

Is this simply what we want for the page? Or do we need to redesign it and discuss with the design team?

This looks good! Do you mind sending a screenshot + staging website link to Design in either Mattermost or Discord, just to confirm with them? @b72zhou

I will also check with the rest of the execs this week to make sure they are happy with the changes as well. 🙂

> https://csclub.uwaterloo.ca/~a3thakra/csc/beihao-separate-teams/about/team/ > > Is this simply what we want for the page? Or do we need to redesign it and discuss with the design team? This looks good! Do you mind sending a screenshot + staging website link to Design in either Mattermost or Discord, just to confirm with them? @b72zhou I will also check with the rest of the execs this week to make sure they are happy with the changes as well. 🙂
👍 1
b72zhou added 1 commit 2022-03-02 00:16:39 -05:00
continuous-integration/drone/push Build is passing Details
3f79eb32dc fix repetition and heading names
b72zhou added 1 commit 2022-03-04 01:43:18 -05:00
continuous-integration/drone/push Build is passing Details
c4796826cf fix image format bug
b72zhou commented 2022-03-04 01:45:46 -05:00
Author
Contributor
Copy Link

Design team has confirmed it looks good to them. All issues mentioned above have been fixed as well:)) @a258wang

Design team has confirmed it looks good to them. All issues mentioned above have been fixed as well:)) @a258wang
n3parikh approved these changes 2022-03-09 02:17:54 -05:00
b72zhou merged commit d04115fb12 into main 2022-03-09 10:03:28 -05:00
Sign in to join this conversation.
Reviewers
No reviewers
a258wang
n3parikh
Labels
Clear labels   
a11y

   
Backlog

   
Blocked

   
Bug

   
Content

   
Dependencies

   
Design

   
Feature Request

   
Good First Issue

   
In Progress

   
Performance

   
Priority - High

   
Priority - Low

   
Priority - Medium

   
Untriaged
No Label
a11y
Backlog
Blocked
Bug
Content
Dependencies
Design
Feature Request
Good First Issue
In Progress
Performance
Priority - High
Priority - Low
Priority - Medium
Untriaged
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: www/www-new#404
No description provided.
Delete Branch "beihao-separate-teams"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?