www
/
www-new
12
3
Fork 5
Code Issues 58 Pull Requests 42 Projects Releases Wiki Activity

richardshuai/karaoke #559

Merged
r2shuai merged 13 commits from richardshuai/karaoke into main 2023-03-02 18:21:29 -05:00
Conversation 0 Commits 13 Files Changed 2 +18
r2shuai commented 2023-02-28 23:30:35 -05:00
Member
Copy Link

Finished Karaoke ad.

https://csclub.uwaterloo.ca/~a3thakra/csc/richardshuai/karaoke/

Finished Karaoke ad. https://csclub.uwaterloo.ca/~a3thakra/csc/richardshuai/karaoke/
r2shuai added 4 commits 2023-02-28 23:30:37 -05:00
continuous-integration/drone/push Build is passing Details
63fe0eeed2 Add Richard Shuai to the website
continuous-integration/drone/push Build is passing Details
26e7429cbe Merge branch 'richardshuai/add-me'
continuous-integration/drone/push Build is failing Details
598dc4511b Karaoke
r2shuai requested review from snedadah 2023-02-28 23:30:56 -05:00
r2shuai added 1 commit 2023-02-28 23:41:56 -05:00
continuous-integration/drone/push Build is failing Details
4a2b6483bd Fixing spaces
snedadah added 1 commit 2023-03-01 15:07:28 -05:00
continuous-integration/drone/push Build is failing Details
eee582581d Merge branch 'main' into richardshuai/karaoke
snedadah added 1 commit 2023-03-01 19:55:20 -05:00
continuous-integration/drone/push Build is failing Details
64b277ffd9 Reverted react type change
snedadah added 1 commit 2023-03-01 19:56:29 -05:00
continuous-integration/drone/push Build is failing Details
f8a44c315e Reverted package lock change
snedadah added 1 commit 2023-03-01 19:59:46 -05:00
continuous-integration/drone/push Build is failing Details
2464963210 Update image
snedadah added 1 commit 2023-03-01 20:01:17 -05:00
continuous-integration/drone/push Build is failing Details
1a841e1563 Added space
snedadah added 1 commit 2023-03-01 20:02:34 -05:00
continuous-integration/drone/push Build is passing Details
c774a88154 Added space
snedadah approved these changes 2023-03-01 20:05:26 -05:00
snedadah left a comment
Owner
Copy Link

LGTM! I just went ahead and changed a few things:

  • I noticed that the CI build was failing: (https://ci.csclub.uwaterloo.ca/www/www-new/1844) You can get that link by clicking the red X beside the commit name in first page) so I looked at the changes to see what caused it:
  • You had made an (accidental?) change to the react version in the package.json, I reverted this change
  • I changed the photo to be the square photo
  • I added a space after emojis to be consistant
  • Added a link to the register link
LGTM! I just went ahead and changed a few things: - I noticed that the CI build was failing: (https://ci.csclub.uwaterloo.ca/www/www-new/1844) You can get that link by clicking the red X beside the commit name in first page) so I looked at the changes to see what caused it: - You had made an (accidental?) change to the react version in the package.json, I reverted this change - I changed the photo to be the square photo - I added a space after emojis to be consistant - Added a link to the register link
👍 1
snedadah added 1 commit 2023-03-01 20:24:36 -05:00
continuous-integration/drone/push Build is passing Details
8343af96f9 Added register link
r2shuai added 1 commit 2023-03-02 18:07:55 -05:00
continuous-integration/drone/push Build is passing Details
92324ab9b5 Merge branch 'main' into richardshuai/karaoke
r2shuai scheduled this pull request to auto merge when all checks succeed 2023-03-02 18:10:13 -05:00
r2shuai merged commit 7a1520b4ec into main 2023-03-02 18:21:29 -05:00
r2shuai referenced this issue from a commit 2023-03-02 18:21:31 -05:00
richardshuai/karaoke (#559)
Sign in to join this conversation.
Reviewers
No reviewers
snedadah
Labels
Clear labels   
a11y

   
Backlog

   
Blocked

   
Bug

   
Content

   
Dependencies

   
Design

   
Feature Request

   
Good First Issue

   
In Progress

   
Performance

   
Priority - High

   
Priority - Low

   
Priority - Medium

   
Untriaged
No Label
a11y
Backlog
Blocked
Bug
Content
Dependencies
Design
Feature Request
Good First Issue
In Progress
Performance
Priority - High
Priority - Low
Priority - Medium
Untriaged
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: www/www-new#559
No description provided.
Delete Branch "richardshuai/karaoke"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?