www
/
www-new
12
3
Fork 5
Code Issues 58 Pull Requests 42 Projects Releases Wiki Activity

Update team name to Community Representatives #478

Merged
a258wang merged 1 commits from amy-update-community-reps into main 2022-07-20 20:09:12 -04:00
Conversation 0 Commits 1 Files Changed 2 +11 -11
2 changed files with 11 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

0
content/team/coordinators-team.json → content/team/representatives-team.json
View File

22
pages/about/team.tsx
View File

@ -16,13 +16,13 @@ import {
getMemberImagePath,
} from "@/lib/team";
import coordinatorsData from "../../content/team/coordinators-team.json";
import designData from "../../content/team/design-team.json";
import discordData from "../../content/team/discord-team.json";
import eventsData from "../../content/team/events-team.json";
import externalData from "../../content/team/external-affairs-team.json";
import marketingData from "../../content/team/marketing-team.json";
import photographyData from "../../content/team/photography-team.json";
import repsData from "../../content/team/representatives-team.json";
import systemsData from "../../content/team/systems-committee.json";
import terminalData from "../../content/team/terminal-committee.json";
import webData from "../../content/team/web-committee.json";
@ -36,13 +36,13 @@ interface SerializedExec {
interface Props {
execs: SerializedExec[];
coordinators: Metadata[];
design: Metadata[];
discord: Metadata[];
events: Metadata[];
external: Metadata[];
marketing: Metadata[];
photography: Metadata[];
representatives: Metadata[];
website: Metadata[];
systems: Metadata[];
terminal: Metadata[];
@ -50,22 +50,22 @@ interface Props {
export default function Team({
execs,
coordinators,
design,
discord,
events,
external,
marketing,
photography,
representatives,
website,
systems,
terminal,
}: Props) {
const teams = [
{
id: "coordinators",
name: "Community Coordinators",
members: coordinators,
id: "reps",
snedadah commented 2022-07-18 13:24:48 -04:00
Review
Copy Link

Do we ever link to this page? Eg. on hiring google forms etc. Since by changing this we will break any older links.

Do we ever link to this page? Eg. on hiring google forms etc. Since by changing this we will break any older links.
a258wang commented 2022-07-20 20:09:03 -04:00
Review
Copy Link

The main reason why we have ids is for the nav at the top of the mobile Meet the Team page - I don't think anyone uses these links outside of the website.

The main reason why we have ids is for the nav at the top of the mobile Meet the Team page - I don't think anyone uses these links outside of the website.
name: "Community Representatives",
members: representatives,
},
{
id: "design",
@ -122,7 +122,7 @@ export default function Team({
<h1 className={styles.header}>Meet the Team!</h1>
<div className={styles.nav}>
<Link href="#execs">The Executives</Link>
<Link href="#coordinators">Community Coordinators</Link>
<Link href="#reps">Community Representatives</Link>
<Link href="#design">Design</Link>
<Link href="#discord">Discord</Link>
<Link href="#events">Events</Link>
@ -233,35 +233,35 @@ export const getStaticProps: GetStaticProps<Props> = async () => {
)) as SerializedExec[];
let [
coordinators,
design,
discord,
events,
external,
marketing,
photography,
representatives,
website,
systems,
terminal,
] = await Promise.all([
getTeamWithImages(coordinatorsData),
getTeamWithImages(designData),
getTeamWithImages(discordData),
getTeamWithImages(eventsData),
getTeamWithImages(externalData),
getTeamWithImages(marketingData),
getTeamWithImages(photographyData),
getTeamWithImages(repsData),
getTeamWithImages(webData),
getTeamWithImages(systemsData),
getTeamWithImages(terminalData),
]);
coordinators = sortTeam(coordinators);
design = sortTeam(design);
discord = sortTeam(discord);
events = sortTeam(events);
external = sortTeam(external);
marketing = sortTeam(marketing);
representatives = sortTeam(representatives);
photography = sortTeam(photography);
website = sortTeam(website);
systems = sortTeam(systems);
@ -270,13 +270,13 @@ export const getStaticProps: GetStaticProps<Props> = async () => {
return {
props: {
execs,
coordinators,
design,
discord,
events,
external,
marketing,
photography,
representatives,
website,
systems,
terminal,