public
/
pyceo
27
1
Fork 3
Code Issues 25 Pull Requests 5 Projects Releases 1 Wiki Activity

TUI position views are broken #124

New Issue
Closed
opened 2024-02-10 11:53:39 -05:00 by merenber · 2 comments
merenber commented 2024-02-10 11:53:39 -05:00
Owner
Copy Link

The "Get positions" and "Set positions" views are a broken due to a regression in 25994af312. The GetPositionsView and SetPositionsView need to be updated to show an empty string if a position is not set (e.g. via positions_names.get(pos, '').

See:

The "Get positions" and "Set positions" views are a broken due to a regression in 25994af3127b2ec26bcbf37ae481bdd04f580fe4. The GetPositionsView and SetPositionsView need to be updated to show an empty string if a position is not set (e.g. via `positions_names.get(pos, '')`. See: * https://git.csclub.uwaterloo.ca/public/pyceo/src/branch/master/ceo/tui/views/GetPositionsView.py#L17 * https://git.csclub.uwaterloo.ca/public/pyceo/src/branch/master/ceo/tui/views/SetPositionsView.py#L19
merenber added the
priority
very high
 label 2024-02-10 11:53:39 -05:00
merenber pinned this 2024-02-10 11:53:49 -05:00
l227zhan commented 2024-02-10 15:33:46 -05:00
Member
Copy Link

Thank you for letting me know, I have pushed 3780662ba4 to resolve this issue.

Thank you for letting me know, I have pushed 3780662ba4 to resolve this issue.
merenber commented 2024-02-10 15:36:11 -05:00
Author
Owner
Copy Link

As mentioned in #125 (comment) - the real problem is that the dict in ceo/tui/views/position_names.py is missing the key "events-lead".

As mentioned in https://git.csclub.uwaterloo.ca/public/pyceo/pulls/125#issuecomment-14347 - the real problem is that the dict in ceo/tui/views/position_names.py is missing the key "events-lead".
merenber reopened this issue 2024-02-10 15:36:11 -05:00
n4chung unpinned this 2024-02-11 22:05:18 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
master
124-fix-regression
new-positions
54-newsletter
WIP-66
65-isClubRep-fix
83-sqlfstrings
60-group-lookup
63-fix-ci
1.0.22
v0.5.1
v0.4.11
v0.4.10
v0.4.9
v0.4.8
v0.4.7
v0.4.6
v0.4.5
Labels
Clear labels   
priority
high
High priority

  
priority
low
Low priority

  
priority
medium
Medium priority

  
priority
very high
Very high priority

  
BUG

   
Feature

   
High Priority

   
Low Priority

   
Medium Priority
No Label
priority
high
priority
low
priority
medium
priority
very high
BUG
Feature
High Priority
Low Priority
Medium Priority
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: public/pyceo#124
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?