public
/
pyceo
27
1
Fork 3
Code Issues 25 Pull Requests 5 Projects Releases 1 Wiki Activity

Fix for regression in issue #124 #125

Merged
l227zhan merged 2 commits from 124-fix-regression into master 2024-02-10 15:32:54 -05:00
Conversation 3 Commits 2 Files Changed 2 +3 -3
l227zhan commented 2024-02-10 15:13:02 -05:00
Member
Copy Link
No description provided.
l227zhan added 1 commit 2024-02-10 15:13:03 -05:00
n4chung approved these changes 2024-02-10 15:14:41 -05:00
n4chung left a comment
Owner
Copy Link

hot

hot
l227zhan added 1 commit 2024-02-10 15:14:54 -05:00
l227zhan merged commit 3780662ba4 into master 2024-02-10 15:32:54 -05:00
l227zhan deleted branch 124-fix-regression 2024-02-10 15:32:54 -05:00
merenber commented 2024-02-10 15:35:36 -05:00
Owner
Copy Link

Ugh, this got merged before I got a chance to comment. What I said in #124 was wrong. We don't want to show an empty string. The real problem is that the dict in ceo/tui/views/position_names.py is missing the key "events-lead".

I'll revert this commit and re-open the issue. Sorry for the confusion.

Ugh, this got merged before I got a chance to comment. What I said in #124 was wrong. We don't want to show an empty string. The real problem is that the dict in ceo/tui/views/position_names.py is missing the key "events-lead". I'll revert this commit and re-open the issue. Sorry for the confusion.
l227zhan commented 2024-02-10 15:43:59 -05:00
Author
Member
Copy Link

Ugh, this got merged before I got a chance to comment. What I said in #124 was wrong. We don't want to show an empty string. The real problem is that the dict in ceo/tui/views/position_names.py is missing the key "events-lead".

I'll revert this commit and re-open the issue. Sorry for the confusion.

Oh lol, my fingers got a little too twitchy haha, will fix.

> Ugh, this got merged before I got a chance to comment. What I said in #124 was wrong. We don't want to show an empty string. The real problem is that the dict in ceo/tui/views/position_names.py is missing the key "events-lead". > > I'll revert this commit and re-open the issue. Sorry for the confusion. Oh lol, my fingers got a little too twitchy haha, will fix.
l227zhan commented 2024-02-10 15:57:42 -05:00
Author
Member
Copy Link

I added it to the dict, but this may change the output of some unit tests once again

I added it to the dict, but this may change the output of some unit tests once again
l227zhan referenced this issue from a commit 2024-02-11 16:33:43 -05:00
See #125 (#127)
Sign in to join this conversation.
Reviewers
No reviewers
n4chung
Labels
Clear labels   
priority
high
High priority

  
priority
low
Low priority

  
priority
medium
Medium priority

  
priority
very high
Very high priority

  
BUG

   
Feature

   
High Priority

   
Low Priority

   
Medium Priority
No Label
priority
high
priority
low
priority
medium
priority
very high
BUG
Feature
High Priority
Low Priority
Medium Priority
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: public/pyceo#125
No description provided.
Delete Branch "124-fix-regression"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?