public
/
pyceo
27
1
Fork 3
Code Issues 25 Pull Requests 5 Projects Releases 1 Wiki Activity

Update available positions in configuration files, pertaining to issue #63 #117

Merged
l227zhan merged 6 commits from new-positions into master 2024-01-22 22:00:32 -05:00
Conversation 2 Commits 6 Files Changed 8 +78 -25
l227zhan commented 2024-01-21 22:08:29 -05:00
Member
Copy Link

Working on adding new positions and deleting legacy positions from CEO.

Testing CI unit testing

Working on adding new positions and deleting legacy positions from CEO. Testing CI unit testing
l227zhan added 1 commit 2024-01-21 22:08:30 -05:00
continuous-integration/drone/pr Build is failing Details
067a559b5a Update available positions in configuration files, pertaining to issue #63 
Added:
`Ext Affairs Lead`
`Marketing Lead`
`Design Lead`
`Events Lead`
`Reps Lead`
`Mods Lead`
`Photography Lead`
`Codey Bot Lead`
`Other`

Removed:
`IMAPD`
`Librarian`

as roles have been vacant.

Updated relevant tests
l227zhan commented 2024-01-21 22:10:24 -05:00
Author
Member
Copy Link

Also I realize that I named my branch contrary to convention, but I don't have permissions to rename branches

Also I realize that I named my branch contrary to convention, but I don't have permissions to rename branches
l227zhan added 1 commit 2024-01-22 19:38:49 -05:00
continuous-integration/drone/pr Build is failing Details
c9ad827c8b I need new test data, added spaces to cli output
l227zhan added 2 commits 2024-01-22 19:43:40 -05:00
l227zhan added 1 commit 2024-01-22 19:47:39 -05:00
continuous-integration/drone/pr Build is failing Details
bd453990c9 Merge branch 'master' into new-positions
l227zhan added 1 commit 2024-01-22 20:08:55 -05:00
l227zhan commented 2024-01-22 20:25:32 -05:00
Author
Member
Copy Link

This change now passes unit tests, as well as a newly added unit test.

This change now passes unit tests, as well as a newly added unit test.
l227zhan changed title from WIP: Update available positions in configuration files, pertaining to issue #63 to Update available positions in configuration files, pertaining to issue #63 2024-01-22 20:25:35 -05:00
l227zhan requested review from n4chung 2024-01-22 20:25:57 -05:00
merenber approved these changes 2024-01-22 20:45:09 -05:00
merenber left a comment
Owner
Copy Link

Looks good to me. Thank you for taking on this long-standing issue!

Looks good to me. Thank you for taking on this long-standing issue!
n4chung approved these changes 2024-01-22 22:00:12 -05:00
n4chung left a comment
Owner
Copy Link

Incredible work Leon!

Incredible work Leon!
l227zhan merged commit 25994af312 into master 2024-01-22 22:00:32 -05:00
Sign in to join this conversation.
Reviewers
No reviewers
merenber
n4chung
Labels
Clear labels   
priority
high
High priority

  
priority
low
Low priority

  
priority
medium
Medium priority

  
priority
very high
Very high priority

  
BUG

   
Feature

   
High Priority

   
Low Priority

   
Medium Priority
No Label
priority
high
priority
low
priority
medium
priority
very high
BUG
Feature
High Priority
Low Priority
Medium Priority
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: public/pyceo#117
No description provided.
Delete Branch "new-positions"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?