public/pyceo
30
1
Fork 5
Code Issues 26 Pull Requests 6 Projects Releases 1 Wiki Activity

Assume program is Alumni if UWLDAP is missing data #84

Merged
merenber merged 1 commits from uwldap-assume-alumni into master 2022-11-01 21:02:06 -04:00
Conversation 1 Commits 1 Files Changed 2 +21 -5
merenber commented 2022-11-01 00:22:29 -04:00
Owner
Copy Link

At some point, I think that UWLDAP had 'ou=Alumni' for alumni, but that is no longer the case. Now, alumni simply don't have an 'ou' attribute at all in UWLDAP. As a result, the updateprograms ceo command currently does not update the CSC LDAP 'program' attribute for people who recently graduated.

This PR sets 'program=Alumni' for members who either do not have an 'ou' attribute in UWLDAP, or who do not have a UWLDAP entry at all.

At some point, I think that UWLDAP had 'ou=Alumni' for alumni, but that is no longer the case. Now, alumni simply don't have an 'ou' attribute at all in UWLDAP. As a result, the `updateprograms` ceo command currently does not update the CSC LDAP 'program' attribute for people who recently graduated. This PR sets 'program=Alumni' for members who either do not have an 'ou' attribute in UWLDAP, or who do not have a UWLDAP entry at all.
merenber added 1 commit 2022-11-01 00:22:31 -04:00
assume alumni if UWLDAP is missing data
All checks were successful
continuous-integration/drone/pr Build is passing
Details
950e794bb7
merenber requested review from r389li 2022-11-01 00:37:01 -04:00
r389li approved these changes 2022-11-01 00:51:32 -04:00
r389li left a comment
Owner
Copy Link

LGTM, thanks merenber

LGTM, thanks merenber
merenber merged commit 1e452d10ce into master 2022-11-01 21:02:06 -04:00
merenber deleted branch uwldap-assume-alumni 2022-11-01 21:02:07 -04:00
Sign in to join this conversation.
Reviewers
No Reviewers
r389li
Labels
Clear labels
priority
high
High priority
priority
low
Low priority
priority
medium
Medium priority
priority
very high
Very high priority
BUG
Feature
High Priority
Low Priority
Medium Priority
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: public/pyceo#84
No description provided.
Delete Branch "uwldap-assume-alumni"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?