www
/
cs-2022-class-profile
16
0
Fork 0
Code Issues 11 Pull Requests 1 Projects Releases Wiki Activity

Make section component body text optional (Closes #70) #77

Merged
snedadah merged 5 commits from opt-descrp into main 2022-11-05 12:18:45 -04:00
Conversation 0 Commits 5 Files Changed 3 +105 -43
snedadah commented 2022-11-05 02:13:32 -04:00
Owner
Copy Link

Also extended and cleaned up the sample page a bit.

https://opt-descrp-csc-class-profile-staging-snedadah.k8s.csclub.cloud/samplePage/

Also extended and cleaned up the sample page a bit. https://opt-descrp-csc-class-profile-staging-snedadah.k8s.csclub.cloud/samplePage/
snedadah added 5 commits 2022-11-05 02:13:33 -04:00
continuous-integration/drone/push Build is passing Details
100043836c Tested out having center with background
continuous-integration/drone/push Build is passing Details
ac49589a53 Added support for centered left/right bubble
continuous-integration/drone/push Build is passing Details
54265c4b08 Cleaned up sample page and removed center background
continuous-integration/drone/push Build is passing Details
e4c9c9f6d8 Fixed removal
snedadah requested review from e26chiu 2022-11-05 02:15:23 -04:00
e26chiu approved these changes 2022-11-05 10:02:55 -04:00
e26chiu left a comment
Contributor
Copy Link

Hey @snedadah ! Another great PR! Enjoyed looking over the code and nice refactoring of magic constants! Makes the page look a lot cleaner!🤩 I don't have much comment since this PR is pretty straightforward. The changes look good on mobile!

Unrelated to this PR, I see that the WordCloud component on mobile adds horizontal scrolling (takes too much horizontal space)

Hey @snedadah ! Another great PR! Enjoyed looking over the code and nice refactoring of magic constants! Makes the page look a lot cleaner!🤩 I don't have much comment since this PR is pretty straightforward. The changes look good on mobile! Unrelated to this PR, I see that the WordCloud component on mobile adds horizontal scrolling (takes too much horizontal space)
e26chiu changed title from Make section component body text optional to Make section component body text optional (Closes #70) 2022-11-05 10:03:19 -04:00
snedadah merged commit 0fcc367ab6 into main 2022-11-05 12:18:45 -04:00
snedadah deleted branch opt-descrp 2022-11-05 12:18:45 -04:00
Sign in to join this conversation.
Reviewers
No reviewers
e26chiu
Labels
Clear labels   
Bug

   
Component

   
Config

   
Good First Issue

   
Low-Priority

   
Page
No Label
Bug
Component
Config
Good First Issue
Low-Priority
Page
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: www/cs-2022-class-profile#77
No description provided.
Delete Branch "opt-descrp"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?