Fixed data and tooltip issues with wordcloud #84
Loading…
Reference in New Issue
No description provided.
Delete Branch "fix-wordcloud-data"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Closes #80
Closes #78
Added finer control for word cloud min/max font sizes. Changed defaults to be a bit more sensible, and also adjusted the values for the demographics page word cloud to display all data (main culprit was "wordPadding" was too big)
Added a console.error for when not all the words are being display to aid in development for when we're adjusting the min/max font sizes.
Fixed word cloud tooltip not being correct on centered word clouds.
Added a min width to the word cloud, aniticipating changes from #85
https://fix-wordcloud-data-csc-class-profile-staging-snedadah.k8s.csclub.cloud/samplePage/
https://fix-wordcloud-data-csc-class-profile-staging-snedadah.k8s.csclub.cloud/demographics/
@snedadah Code mostly LGTM! I like the fix on the tooltip with the offset so that it doesn't go out of bounds. NITPICKS: The WordCloud for the Demographics page looks a bit cramped on Desktop. We can up the wordPadding probably a little bit. There is also a bit of space in the mobile version (see attached image)
There is still the possibility that the WordCloud can overflow on Desktop while resizing the window although we can adjust the props (wordPadding, desktopMinFontSize, etc.) to make it fit.
Note to be fixed in future PR: WordCloud + text at screen width 1100px is not the most visually appealing.
@ -0,0 +1,7 @@
let inDevEnvironment = false;
We can also write it this way to make it more concise?
T
The word cloud doesn't actually overflow, it just doesnt resize. If you refresh the page after resizing it should be fixed. I'm not sure why it doesn't fix it self when resizing :(