add stats #302

merenber · 2021-09-07T18:32:23-04:00

merenber commented

2021-09-07 18:32:23 -04:00

The old website had a /stats page which showed metrics for several campus network interfaces.
This PR adds them back in.

The old website had a `/stats` page which showed metrics for several campus network interfaces. This PR adds them back in.

merenber added 1 commit 2021-09-07 18:32:24 -04:00

continuous-integration/drone/push Build is passing Details

88227ea07c add stats

merenber requested review from a3thakra 2021-09-07 18:32:31 -04:00

merenber commented

2021-09-07 18:33:21 -04:00

On a side note, why do we set trailingSlash to true? I find it rather ugly to append a slash to all of our page URLs.

On a side note, why do we set `trailingSlash` to true? I find it rather ugly to append a slash to all of our page URLs.

a3thakra commented

2021-09-07 18:49:28 -04:00

On a side note, why do we set trailingSlash to true? I find it rather ugly to append a slash to all of our page URLs.

We set it to true to maintain compatibility with dev mode.

> On a side note, why do we set trailingSlash to true? I find it rather ugly to append a slash to all of our page URLs. We set it to true to maintain compatibility with dev mode.

a3thakra commented

2021-09-07 18:53:44 -04:00

Do you know if people use this page?
Why does it need to be it's own weird html page, without the CSC navbar etc? Why not create a stats.tsx file under the pages directory?
If it's not urgent, I would also like to involve design for this page.

- Do you know if people use this page? - Why does it need to be it's own weird html page, without the CSC navbar etc? Why not create a stats.tsx file under the pages directory? - If it's not urgent, I would also like to involve design for this page.

merenber commented

2021-09-07 21:17:35 -04:00

This page is pretty much only used by syscom. I just copied it from the old website.
We'd strongly prefer to keep it as raw HTML + CSS, since we will be the ones updating this page in the future, and a raw HTML page is easier to edit.

This page is pretty much only used by syscom. I just copied it from the old website. We'd strongly prefer to keep it as raw HTML + CSS, since we will be the ones updating this page in the future, and a raw HTML page is easier to edit.

merenber commented

2021-09-07 21:18:50 -04:00

On a side note, why do we set trailingSlash to true? I find it rather ugly to append a slash to all of our page URLs.

We set it to true to maintain compatibility with dev mode.

Is there a way we can take this out? I think the trailing slashes look ugly.
(If it's a huge hassle then don't bother.)

> > On a side note, why do we set trailingSlash to true? I find it rather ugly to append a slash to all of our page URLs. > > We set it to true to maintain compatibility with dev mode. > > Is there a way we can take this out? I think the trailing slashes look ugly. (If it's a huge hassle then don't bother.)

a3thakra commented

2021-09-07 22:01:37 -04:00

On a side note, why do we set trailingSlash to true? I find it rather ugly to append a slash to all of our page URLs.

We set it to true to maintain compatibility with dev mode.

Is there a way we can take this out? I think the trailing slashes look ugly.
(If it's a huge hassle then don't bother.)

No, it will break most of our links. If we disable it, all pages will be exported with a trailing .html - eg: /about.html, /about/team.html, etc. But while developing the website, the URLs will be /about, /about/team, etc.

You also don't really need the trailing slashes afaik. If you enter the URL without the trailing slash, it still works.

> > > On a side note, why do we set trailingSlash to true? I find it rather ugly to append a slash to all of our page URLs. > > > > We set it to true to maintain compatibility with dev mode. > > > > > > Is there a way we can take this out? I think the trailing slashes look ugly. > (If it's a huge hassle then don't bother.) No, it will break most of our links. If we disable it, all pages will be exported with a trailing `.html` - eg: `/about.html`, `/about/team.html`, etc. But while developing the website, the URLs will be `/about`, `/about/team`, etc. You also don't really need the trailing slashes afaik. If you enter the URL without the trailing slash, it still works.

merenber commented

2021-09-07 22:21:35 -04:00

You also don't really need the trailing slashes afaik. If you enter the URL without the trailing slash, it still works.

Alright, fair enough.

> You also don't really need the trailing slashes afaik. If you enter the URL without the trailing slash, it still works. Alright, fair enough.

n3parikh commented

2021-09-08 01:38:40 -04:00

This looks good to me.

We should namespace this page (and similar pages in the future) under something like /syscom (ie. make the URL /syscom/stats), just so it's obvious it's for internal use.

This looks good to me. We should namespace this page (and similar pages in the future) under something like `/syscom` (ie. make the URL `/syscom/stats`), just so it's obvious it's for internal use.

merenber commented

2021-09-09 18:17:35 -04:00

Unless there are any strong objections, I'm going to merge this one in.

merenber merged commit b46c8d3d5a into main

2021-09-10 08:53:38 -04:00

merenber referenced this issue from a commit

2021-09-10 08:53:39 -04:00

add stats (#302)

merenber deleted branch merenber-stats

2021-09-10 08:53:47 -04:00

Sign in to join this conversation.

No reviewers