Clean up Shapes Backgrounds on some mobile pages #307

a258wang · 2021-09-07T23:49:14-04:00

a258wang commented

2021-09-07 23:49:14 -04:00

Addresses some of the shapes shenanigans that I noticed here: #236 (comment)

Removed shapes from mobile /events/[year]/[term]/[event] page. (I left the default shapes on the mobile /events/[year]/[term] page, since with the vertical nav header they now fit, but I'd love to hear others' opinions on this!)
Adjusted top margins on mobile Meet the Team, Our Supporters, and Tech Talks/Tech Talk pages to accommodate the shapes.
Changed shapes on mobile Home page to accommodate the expanded Social Links.

Addresses some of the shapes shenanigans that I noticed here: https://git.csclub.uwaterloo.ca/www/www-new/issues/236#issuecomment-2450 - Removed shapes from mobile /events/\[year\]/\[term\]/\[event\] page. (I left the default shapes on the mobile /events/\[year\]/\[term\] page, since with the vertical nav header they now fit, but I'd love to hear others' opinions on this!) - Adjusted top margins on mobile Meet the Team, Our Supporters, and Tech Talks/Tech Talk pages to accommodate the shapes. - Changed shapes on mobile Home page to accommodate the expanded Social Links.

a258wang added 1 commit 2021-09-07 23:49:15 -04:00

continuous-integration/drone/push Build is passing Details

6748c24ee8 Clean up shapes on some mobile pages

a258wang changed title from ~~Clean up Shapes Backgrounds on some mobile pages~~ to WIP: Clean up Shapes Backgrounds on some mobile pages

2021-09-07 23:52:25 -04:00

a258wang added 2 commits 2021-09-08 00:03:49 -04:00

fcc52791f9 Adjust shapes on mobile Our Supporters page

continuous-integration/drone/push Build is passing Details

8cc717e91f Adjust shapes on mobile Home page

a258wang changed title from ~~WIP: Clean up Shapes Backgrounds on some mobile pages~~ to Clean up Shapes Backgrounds on some mobile pages

2021-09-08 00:05:12 -04:00

a3thakra commented

2021-09-15 22:56:52 -04:00

Removed shapes from mobile /events/[year]/[term]/[event] page. (I left the default shapes on the mobile /events/[year]/[term] page, since with the vertical nav header they now fit, but I'd love to hear others' opinions on this!)

✅

I agree, no need to remove them if they look fine!

Adjusted top margins on mobile Meet the Team, Our Supporters, and Tech Talks/Tech Talk pages to accommodate the shapes.

✅

Changed shapes on mobile Home page to accommodate the expanded Social Links.

✅

> Removed shapes from mobile /events/[year]/[term]/[event] page. (I left the default shapes on the mobile /events/[year]/[term] page, since with the vertical nav header they now fit, but I'd love to hear others' opinions on this!) ✅ I agree, no need to remove them if they look fine! > Adjusted top margins on mobile Meet the Team, Our Supporters, and Tech Talks/Tech Talk pages to accommodate the shapes. ✅ > Changed shapes on mobile Home page to accommodate the expanded Social Links. ✅

a3thakra approved these changes 2021-09-15 22:58:04 -04:00

a3thakra left a comment

code lgtm

a258wang merged commit 623e1bd52d into main

2021-09-15 23:17:19 -04:00

a258wang referenced this issue from a commit

2021-09-15 23:17:20 -04:00

Clean up Shapes Backgrounds on some mobile pages (#307)

a3thakra deleted branch amy-adjust-mobile-shapes-background

2021-09-15 23:28:08 -04:00

Sign in to join this conversation.

No reviewers