Advice + Internships Page #161

Merged
l42luo merged 9 commits from feat/advice-page into main 1 year ago
l42luo commented 1 year ago
Collaborator

Closes #140
Closes #141

Closes #140 Closes #141
l42luo added 2 commits 1 year ago
b352aa64ce initial commit for advice page
l42luo added 1 commit 1 year ago
l42luo changed title from WIP: Advice Page to WIP: Advice + Internships Page 1 year ago
l42luo added 1 commit 1 year ago
c66fe32e9c simplified colouring current advice subheading
l42luo changed title from WIP: Advice + Internships Page to Advice + Internships Page 1 year ago
l42luo added 1 commit 1 year ago
a3thakra reviewed 1 year ago
import { Advice } from "./coop";
export default function CoopAdvice() {
Collaborator

AcademicAdvice

AcademicAdvice
l42luo marked this conversation as resolved
a3thakra reviewed 1 year ago
import { Advice } from "./coop";
export default function CoopAdvice() {
Collaborator

MiscAdvice

MiscAdvice
l42luo marked this conversation as resolved
Collaborator
  • Mobile view is a bit weird.
  • The <hr />s look a bit weird, can you make a custom <hr /> component under components with better styles, and then use that in _app.tsx so that it's changed to our custom component wherever we're using an hr?
- Mobile view is a bit weird. - The `<hr />`s look a bit weird, can you make a custom `<hr />` component under components with better styles, and then use that in `_app.tsx` so that it's changed to our custom component wherever we're using an hr?
63 KiB
112 KiB
l42luo added 1 commit 1 year ago
c72bc42053 added mobile styling
l42luo added 2 commits 1 year ago
l42luo added 1 commit 1 year ago
6ac008a3b7 Merge branch 'main' into feat/advice-page
Collaborator

LGTM, ship it.

LGTM, ship it.
a3thakra approved these changes 1 year ago
l42luo merged commit 09c704c94c into main 1 year ago
l42luo referenced this issue from a commit 1 year ago
l42luo deleted branch feat/advice-page 1 year ago

Reviewers

a3thakra approved these changes 1 year ago
continuous-integration/drone/push Build is passing
The pull request has been merged as 09c704c94c.
Sign in to join this conversation.
No reviewers
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: www/www-new#161
Loading…
There is no content yet.