www
/
www-new
12
3
Fork 5
Code Issues 58 Pull Requests 42 Projects Releases Wiki Activity

Advice + Internships Page #161

Merged
l42luo merged 9 commits from feat/advice-page into main 2021-08-23 14:31:06 -04:00
Conversation 2 Commits 9 Files Changed 13 +390 -9064
l42luo commented 2021-08-19 01:10:15 -04:00
Member
Copy Link

Closes #140
Closes #141

Closes #140 Closes #141
l42luo added 2 commits 2021-08-19 01:10:17 -04:00
continuous-integration/drone/push Build is failing Details
b352aa64ce initial commit for advice page
l42luo added 1 commit 2021-08-22 21:24:31 -04:00
l42luo changed title from WIP: Advice Page to WIP: Advice + Internships Page 2021-08-22 21:27:25 -04:00
l42luo added 1 commit 2021-08-22 21:36:34 -04:00
continuous-integration/drone/push Build is passing Details
c66fe32e9c simplified colouring current advice subheading
l42luo changed title from WIP: Advice + Internships Page to Advice + Internships Page 2021-08-22 21:36:56 -04:00
l42luo added 1 commit 2021-08-22 22:09:35 -04:00
a3thakra reviewed 2021-08-23 09:29:40 -04:00
pages/resources/advice/academic.tsx Outdated
@ -0,0 +4,4 @@
import { Advice } from "./coop";
export default function CoopAdvice() {
a3thakra commented 2021-08-23 09:29:40 -04:00
Owner
Copy Link

AcademicAdvice

AcademicAdvice
l42luo marked this conversation as resolved
a3thakra reviewed 2021-08-23 09:30:22 -04:00
pages/resources/advice/misc.tsx Outdated
@ -0,0 +4,4 @@
import { Advice } from "./coop";
export default function CoopAdvice() {
a3thakra commented 2021-08-23 09:30:22 -04:00
Owner
Copy Link

MiscAdvice

MiscAdvice
l42luo marked this conversation as resolved
a3thakra commented 2021-08-23 09:35:27 -04:00
Owner
Copy Link
  • Mobile view is a bit weird.
  • The <hr />s look a bit weird, can you make a custom <hr /> component under components with better styles, and then use that in _app.tsx so that it's changed to our custom component wherever we're using an hr?
- Mobile view is a bit weird. - The `<hr />`s look a bit weird, can you make a custom `<hr />` component under components with better styles, and then use that in `_app.tsx` so that it's changed to our custom component wherever we're using an hr?
2.png
63 KiB
1.png
112 KiB
2.png 1.png
l42luo added 1 commit 2021-08-23 12:16:29 -04:00
continuous-integration/drone/push Build is passing Details
c72bc42053 added mobile styling
l42luo added 2 commits 2021-08-23 14:14:31 -04:00
continuous-integration/drone/push Build is passing Details
e8c1dcdf2a added custom hr component
l42luo added 1 commit 2021-08-23 14:15:42 -04:00
continuous-integration/drone/push Build is passing Details
6ac008a3b7 Merge branch 'main' into feat/advice-page
a3thakra commented 2021-08-23 14:24:57 -04:00
Owner
Copy Link

LGTM, ship it.

LGTM, ship it.
a3thakra approved these changes 2021-08-23 14:25:13 -04:00
l42luo merged commit 09c704c94c into main 2021-08-23 14:31:06 -04:00
l42luo deleted branch feat/advice-page 2021-08-23 14:31:14 -04:00
Sign in to join this conversation.
Reviewers
No reviewers
a3thakra
Labels
Clear labels   
a11y

   
Backlog

   
Blocked

   
Bug

   
Content

   
Dependencies

   
Design

   
Feature Request

   
Good First Issue

   
In Progress

   
Performance

   
Priority - High

   
Priority - Low

   
Priority - Medium

   
Untriaged
No Label
a11y
Backlog
Blocked
Bug
Content
Dependencies
Design
Feature Request
Good First Issue
In Progress
Performance
Priority - High
Priority - Low
Priority - Medium
Untriaged
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: www/www-new#161
No description provided.
Delete Branch "feat/advice-page"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?