Advice + Internships Page #161

Merged
l42luo merged 9 commits from feat/advice-page into main 2021-08-23 14:31:06 -04:00
Member

Closes #140
Closes #141

Closes #140 Closes #141
l42luo added 2 commits 2021-08-19 01:10:17 -04:00
initial commit for advice page
Some checks failed
continuous-integration/drone/push Build is failing
b352aa64ce
created mdx files for coop, academic and additional resources
All checks were successful
continuous-integration/drone/push Build is passing
3c7d8edf7b
l42luo added 1 commit 2021-08-22 21:24:31 -04:00
added internship page link, refactored Advice component, applied colour to advice subheadings
All checks were successful
continuous-integration/drone/push Build is passing
ebbd5ce7f5
l42luo changed title from WIP: Advice Page to WIP: Advice + Internships Page 2021-08-22 21:27:25 -04:00
l42luo added 1 commit 2021-08-22 21:36:34 -04:00
simplified colouring current advice subheading
All checks were successful
continuous-integration/drone/push Build is passing
c66fe32e9c
l42luo changed title from WIP: Advice + Internships Page to Advice + Internships Page 2021-08-22 21:36:56 -04:00
l42luo added 1 commit 2021-08-22 22:09:35 -04:00
reuse Advice component, modify changing advice subheading colour
All checks were successful
continuous-integration/drone/push Build is passing
ea5003fc5d
a3thakra reviewed 2021-08-23 09:29:40 -04:00
@ -0,0 +4,4 @@
import { Advice } from "./coop";
export default function CoopAdvice() {
Owner

AcademicAdvice

AcademicAdvice
l42luo marked this conversation as resolved
a3thakra reviewed 2021-08-23 09:30:22 -04:00
@ -0,0 +4,4 @@
import { Advice } from "./coop";
export default function CoopAdvice() {
Owner

MiscAdvice

MiscAdvice
l42luo marked this conversation as resolved
Owner
  • Mobile view is a bit weird.
  • The <hr />s look a bit weird, can you make a custom <hr /> component under components with better styles, and then use that in _app.tsx so that it's changed to our custom component wherever we're using an hr?
- Mobile view is a bit weird. - The `<hr />`s look a bit weird, can you make a custom `<hr />` component under components with better styles, and then use that in `_app.tsx` so that it's changed to our custom component wherever we're using an hr?
63 KiB
112 KiB
l42luo added 1 commit 2021-08-23 12:16:29 -04:00
added mobile styling
All checks were successful
continuous-integration/drone/push Build is passing
c72bc42053
l42luo added 2 commits 2021-08-23 14:14:31 -04:00
added custom hr component
All checks were successful
continuous-integration/drone/push Build is passing
e8c1dcdf2a
l42luo added 1 commit 2021-08-23 14:15:42 -04:00
Merge branch 'main' into feat/advice-page
All checks were successful
continuous-integration/drone/push Build is passing
6ac008a3b7
Owner

LGTM, ship it.

LGTM, ship it.
a3thakra approved these changes 2021-08-23 14:25:13 -04:00
l42luo merged commit 09c704c94c into main 2021-08-23 14:31:06 -04:00
l42luo deleted branch feat/advice-page 2021-08-23 14:31:14 -04:00
Sign in to join this conversation.
No Reviewers
No Milestone
No project
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: www/www-new#161
No description provided.