www
/
www-new
15
3
Fork 5
Code Issues 58 Pull Requests 45 Projects Releases Wiki Activity

Warning Header (Closes #205) #394

Merged
snedadah merged 19 commits from warning-header into main 2022-02-22 23:29:55 -05:00
Conversation 3 Commits 19 Files Changed 10 +2 -2
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit e4a4c62b93 - Show all commits

2
components/WarningHeader.module.css
View File

@ -7,5 +7,5 @@
opacity: 1;
max-height: 500px; /* just for smooth fade in purposes */
transition: max-height 100ms ease-in;
transition: max-height 1000ms ease-in, padding 100ms ease-in;
}

2
components/WarningHeader.tsx
View File

@ -25,7 +25,7 @@ export function WarningHeader() {
return (
<div
className={styles.warning}
style={{ maxHeight: 0, opacity: 0 }}
style={{ maxHeight: 0, opacity: 0, padding: 0 }}
snedadah marked this conversation as resolved
a258wang commented 2022-02-22 16:41:55 -05:00
Review
Copy Link

Do we really need this comment here? I personally think the comment on line 25, along with the general structure of the code, are already sufficient to convey what is happening and why.

Do we really need this comment here? I personally think the comment on line 25, along with the general structure of the code, are already sufficient to convey what is happening and why.
></div>
snedadah marked this conversation as resolved Outdated
a3thakra commented 2022-02-16 02:10:54 -05:00
Outdated
Review
Copy Link

instead of setting the currentWarning, you should use a declarative approach:

const currentWarnings = warnings.filter(warning => ...do the thing to filter by date...);
instead of setting the `currentWarning`, you should use a declarative approach: ```ts const currentWarnings = warnings.filter(warning => ...do the thing to filter by date...); ```
);
}
snedadah marked this conversation as resolved Outdated
a3thakra commented 2022-02-16 03:57:02 -05:00
Outdated
Review
Copy Link

I would recommend throwing instead of logging the error. Just logging the error makes us deal with things that aren't defined. If we throw, we don't have to deal with undefined behavior.

I would recommend throwing instead of logging the error. Just logging the error makes us deal with things that aren't defined. If we throw, we don't have to deal with undefined behavior.