About Us page #70

Merged
l42luo merged 21 commits from feat/about-us-page into main 2 years ago
l42luo commented 2 years ago (Migrated from git.uwaterloo.ca)
Collaborator

Fixes #7

Fixes #7
l42luo added 11 commits 2 years ago
l42luo added 4 commits 2 years ago
a3thakra reviewed 2 years ago
font-size: 48px;
height: 80px;
margin-top: auto;
padding-left: 20px;
Collaborator

rems everywhere pls!

rems everywhere pls!
l42luo marked this conversation as resolved
a3thakra reviewed 2 years ago
</div>
<div className={styles.headings}>
<div className={styles.text}>
<Content />
Collaborator

any reason why <Content /> is nested under two divs?

also, i think a better classname for the div wrapping <Content /> would be content :P

any reason why `<Content />` is nested under two divs? also, i think a better classname for the div wrapping `<Content />` would be `content` :P
l42luo marked this conversation as resolved
Collaborator

So close now!!! 🎉 🎉

So close now!!! 🎉 :tada:
l42luo added 1 commit 2 years ago
c516809094 addressed PR comments
a3thakra approved these changes 2 years ago
a3thakra merged commit f670247ec5 into main 2 years ago
a3thakra referenced this issue from a commit 2 years ago
a3thakra deleted branch feat/about-us-page 2 years ago

Reviewers

a3thakra approved these changes 2 years ago
continuous-integration/drone/push Build is passing
The pull request has been merged as f670247ec5.
Sign in to join this conversation.
No reviewers
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: www/www-new#70
Loading…
There is no content yet.