www
/
www-new
12
2
Fork 3
Code Issues 56 Pull Requests 29 Projects Releases Wiki Activity
Labels Milestones

About Us page #70

Merged
l42luo merged 21 commits from feat/about-us-page into main 2 years ago
Conversation 1 Commits 21 Files Changed 14
l42luo commented 2 years ago (Migrated from git.uwaterloo.ca)
Collaborator

Fixes #7

Fixes #7
l42luo added 11 commits 2 years ago
continuous-integration/drone/push Build is passing
Details
445e8933c6 Merge branch 'main' into feat/about-us-page
l42luo added 4 commits 2 years ago
a3thakra reviewed 2 years ago
pages/about/index.module.css Outdated
font-size: 48px;
height: 80px;
margin-top: auto;
padding-left: 20px;
a3thakra commented 2 years ago
Collaborator

rems everywhere pls!

rems everywhere pls!
l42luo marked this conversation as resolved
a3thakra reviewed 2 years ago
pages/about/index.tsx Outdated
</div>
<div className={styles.headings}>
<div className={styles.text}>
<Content />
a3thakra commented 2 years ago
Collaborator

any reason why <Content /> is nested under two divs?

also, i think a better classname for the div wrapping <Content /> would be content :P

any reason why `<Content />` is nested under two divs? also, i think a better classname for the div wrapping `<Content />` would be `content` :P
l42luo marked this conversation as resolved
a3thakra commented 2 years ago
Collaborator

So close now!!! 🎉 🎉

So close now!!! 🎉 :tada:
l42luo added 1 commit 2 years ago
continuous-integration/drone/push Build is passing
Details
c516809094 addressed PR comments
a3thakra approved these changes 2 years ago
a3thakra merged commit f670247ec5 into main 2 years ago
a3thakra referenced this issue from a commit 2 years ago
About Us page (#70)
a3thakra deleted branch feat/about-us-page 2 years ago

Reviewers

a3thakra approved these changes 2 years ago
continuous-integration/drone/push Build is passing
Details
The pull request has been merged as f670247ec5.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
a3thakra
Labels
Apply labels
Clear labels
a11y Backlog Blocked Bug Content Dependencies Design Feature Request Good First Issue In Progress Performance Priority - High Priority - Low Priority - Medium Untriaged
No Label a11y Backlog Blocked Bug Content Dependencies Design Feature Request Good First Issue In Progress Performance Priority - High Priority - Low Priority - Medium Untriaged
Milestone
Set milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: www/www-new#70
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'feat/about-us-page'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes