www
/
www-new
16
3
Fork 8
Code Issues 60 Pull Requests 48 Projects Releases Wiki Activity

About Us page #70

Merged
l42luo merged 21 commits from feat/about-us-page into main 2021-07-18 03:37:49 -04:00
Conversation 1 Commits 21 Files Changed 14 +307 -13
l42luo commented 2021-06-20 17:31:22 -04:00 (Migrated from git.uwaterloo.ca)
Copy Link

Fixes #7

Fixes #7
l42luo added 11 commits 2021-07-08 20:15:00 -04:00
continuous-integration/drone/push Build is passing Details
445e8933c6 Merge branch 'main' into feat/about-us-page 
merging main with feat/about-us-page branch
l42luo added 4 commits 2021-07-13 00:47:36 -04:00
a3thakra reviewed 2021-07-13 00:57:53 -04:00
pages/about/index.module.css Outdated
@ -0,0 +3,4 @@
font-size: 48px;
height: 80px;
margin-top: auto;
padding-left: 20px;
a3thakra commented 2021-07-13 00:57:53 -04:00
Copy Link

rems everywhere pls!

rems everywhere pls!
l42luo marked this conversation as resolved
a3thakra reviewed 2021-07-13 01:00:22 -04:00
pages/about/index.tsx Outdated
@ -0,0 +14,4 @@
</div>
<div className={styles.headings}>
<div className={styles.text}>
<Content />
a3thakra commented 2021-07-13 01:00:21 -04:00
Copy Link

any reason why <Content /> is nested under two divs?

also, i think a better classname for the div wrapping <Content /> would be content :P

any reason why `<Content />` is nested under two divs? also, i think a better classname for the div wrapping `<Content />` would be `content` :P
l42luo marked this conversation as resolved
a3thakra commented 2021-07-13 01:07:07 -04:00
Copy Link

So close now!!! 🎉 🎉

So close now!!! 🎉 :tada:
l42luo added 1 commit 2021-07-13 10:13:40 -04:00
continuous-integration/drone/push Build is passing Details
c516809094 addressed PR comments
a3thakra approved these changes 2021-07-18 03:37:24 -04:00
a3thakra merged commit f670247ec5 into main 2021-07-18 03:37:49 -04:00
a3thakra referenced this issue from a commit 2021-07-18 03:37:50 -04:00
About Us page (#70)
a3thakra deleted branch feat/about-us-page 2021-07-18 03:38:04 -04:00
Sign in to join this conversation.
Reviewers
No reviewers
a3thakra
Labels
Clear labels   
a11y

   
Backlog

   
Blocked

   
Bug

   
Content

   
Dependencies

   
Design

   
Feature Request

   
Good First Issue

   
In Progress

   
Performance

   
Priority - High

   
Priority - Low

   
Priority - Medium

   
Untriaged
No Label
a11y
Backlog
Blocked
Bug
Content
Dependencies
Design
Feature Request
Good First Issue
In Progress
Performance
Priority - High
Priority - Low
Priority - Medium
Untriaged
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: www/www-new#70
No description provided.
Delete Branch "feat/about-us-page"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?