Get Involved Page! #76
No reviewers
Labels
No Label
a11y
Backlog
Blocked
Bug
Content
Dependencies
Design
Feature Request
Good First Issue
In Progress
Performance
Priority - High
Priority - Low
Priority - Medium
Untriaged
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: www/www-new#76
Loading…
Reference in New Issue
No description provided.
Delete Branch "feat/get-involved-page"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
closes #13 and #24
<EmailSignup>
and<ConnectWithUs>
components!Two different codeys (mobile vs desktop) is most likely a mistake. Confirm with design about this.
@ -0,0 +9,4 @@
}
.socialLinks {
margin: calc(36rem / 16) calc(-10rem / 16);
Change the CSS of the Social links component instead. Make sure that the first child of SocialLinks has margin-left: 0 and last child of SocialLinks has margin-right: 0
@ -0,0 +5,4 @@
export function ConnectWithUs() {
return (
<div>
<section>
tag instead? 🤔 What do you think?@ -0,0 +13,4 @@
}
.socialLinks > * {
justify-content: left;
same here, change the css in the social links component so it does not center all the links.
@ -0,0 +19,4 @@
@media only screen and (max-width: calc(768rem / 16)) {
.header {
font-size: calc(24rem / 16);
line-height: calc(36rem / 16);
This is wrong for two reasons:
In this case, line-height would become 1.5, which is already the case for all headings. (_app.css) So you shouldn't need to set it here.
@ -0,0 +19,4 @@
@media only screen and (max-width: calc(768rem / 16)) {
.container > * {
margin: 0 0 calc(15rem / 16) 0;
might as well make it 1 rem lol
@ -0,0 +5,4 @@
export function EmailSignup() {
return (
<div className={styles.container}>
<section>
tag here too?@ -0,0 +10,4 @@
<form className={styles.form} action="">
<Input type="text" placeholder="Full Name*" required />
<Input type="email" placeholder="Email*" required />
<Button className={styles.button}>Subscribe</Button>
use
<Button type="submit"
so that people can press enter inside aninput
to subscribe.@ -0,0 +3,4 @@
}
.container > * {
margin: 0 0 calc(21rem / 16) 0;
add a padding to the container instead
@ -0,0 +2,4 @@
display: block;
width: 100%;
margin: calc(21rem / 16) 0;
padding: calc(10rem / 16) calc(31rem / 16);
can we do
padding: calc(10rem / 16) calc(32rem / 16);
pls 🙈@ -0,0 +1,17 @@
## How to Join
Make sure that the content matches the content on notion:
https://www.notion.so/Get-Involved-DONE-4dd998c0c13d428894961796942fcaef
@ -0,0 +7,4 @@
import styles from "./get-involved.module.css";
/**
* @todo fix codey image with svg
? is it not fixed?
@ -0,0 +70,4 @@
margin-top: calc(50rem / 16);
}
/* @todo aaaaaa */
is it still not fixed?