Get Involved Page! #76

Merged
dora merged 14 commits from feat/get-involved-page into main 2021-07-22 14:42:40 -04:00
dora commented 2021-06-27 05:25:50 -04:00 (Migrated from git.uwaterloo.ca)

closes #13 and #24

  • added the <EmailSignup> and <ConnectWithUs> components!
  • adds the Get Involved Page
closes #13 and #24 - added the `<EmailSignup>` and `<ConnectWithUs>` components! - adds the Get Involved Page
d43su added 1 commit 2021-07-04 00:50:09 -04:00
continuous-integration/drone/push Build is passing Details
d477989fc3
Merge branch 'main' into feat/get-involved-page
d43su added 3 commits 2021-07-04 00:55:39 -04:00
d43su added 1 commit 2021-07-04 00:56:03 -04:00
continuous-integration/drone/push Build is passing Details
f589b05fb8
mobile styles and images

Two different codeys (mobile vs desktop) is most likely a mistake. Confirm with design about this.

Two different codeys (mobile vs desktop) is most likely a mistake. Confirm with design about this.
d43su added 1 commit 2021-07-04 19:18:14 -04:00
continuous-integration/drone/push Build is passing Details
48abedd17d
new desktop codey image
a3thakra reviewed 2021-07-12 19:55:13 -04:00
@ -0,0 +9,4 @@
}
.socialLinks {
margin: calc(36rem / 16) calc(-10rem / 16);

Change the CSS of the Social links component instead. Make sure that the first child of SocialLinks has margin-left: 0 and last child of SocialLinks has margin-right: 0

Change the CSS of the Social links component instead. Make sure that the first child of SocialLinks has margin-left: 0 and last child of SocialLinks has margin-right: 0
a3thakra marked this conversation as resolved
a3thakra reviewed 2021-07-12 19:56:04 -04:00
@ -0,0 +5,4 @@
export function ConnectWithUs() {
return (
<div>

<section> tag instead? 🤔 What do you think?

`<section>` tag instead? :thinking: What do you think?
a3thakra marked this conversation as resolved
a3thakra reviewed 2021-07-12 23:51:22 -04:00
@ -0,0 +13,4 @@
}
.socialLinks > * {
justify-content: left;

same here, change the css in the social links component so it does not center all the links.

same here, change the css in the social links component so it does not center all the links.
a3thakra marked this conversation as resolved
a3thakra reviewed 2021-07-12 23:54:43 -04:00
@ -0,0 +19,4 @@
@media only screen and (max-width: calc(768rem / 16)) {
.header {
font-size: calc(24rem / 16);
line-height: calc(36rem / 16);

This is wrong for two reasons:

  • line-height should be a unitless value.
  • if you are using a unitless value, then you should not be dividing by 16, but should be dividing by what the font-size is (36 / 24)

In this case, line-height would become 1.5, which is already the case for all headings. (_app.css) So you shouldn't need to set it here.

This is wrong for two reasons: - line-height should be a **unitless** value. - if you are using a unitless value, then you should not be dividing by 16, but should be dividing by what the font-size is (36 / 24) In this case, line-height would become 1.5, which is already the case for all headings. (_app.css) So you shouldn't need to set it here.
a3thakra marked this conversation as resolved
a3thakra reviewed 2021-07-13 00:06:19 -04:00
@ -0,0 +19,4 @@
@media only screen and (max-width: calc(768rem / 16)) {
.container > * {
margin: 0 0 calc(15rem / 16) 0;

might as well make it 1 rem lol

might as well make it 1 rem lol
a3thakra marked this conversation as resolved
a3thakra reviewed 2021-07-13 00:07:00 -04:00
@ -0,0 +5,4 @@
export function EmailSignup() {
return (
<div className={styles.container}>

<section> tag here too?

`<section>` tag here too?
a3thakra reviewed 2021-07-13 00:13:48 -04:00
@ -0,0 +10,4 @@
<form className={styles.form} action="">
<Input type="text" placeholder="Full Name*" required />
<Input type="email" placeholder="Email*" required />
<Button className={styles.button}>Subscribe</Button>

use <Button type="submit" so that people can press enter inside an input to subscribe.

use `<Button type="submit"` so that people can press enter inside an `input` to subscribe.
a3thakra marked this conversation as resolved
a3thakra reviewed 2021-07-13 00:14:27 -04:00
@ -0,0 +3,4 @@
}
.container > * {
margin: 0 0 calc(21rem / 16) 0;

add a padding to the container instead

add a padding to the container instead
a3thakra marked this conversation as resolved
a3thakra reviewed 2021-07-13 00:15:38 -04:00
@ -0,0 +2,4 @@
display: block;
width: 100%;
margin: calc(21rem / 16) 0;
padding: calc(10rem / 16) calc(31rem / 16);

can we do padding: calc(10rem / 16) calc(32rem / 16); pls 🙈

can we do `padding: calc(10rem / 16) calc(32rem / 16);` pls 🙈
a3thakra marked this conversation as resolved
a3thakra reviewed 2021-07-13 00:22:39 -04:00
@ -0,0 +1,17 @@
## How to Join

Make sure that the content matches the content on notion:

https://www.notion.so/Get-Involved-DONE-4dd998c0c13d428894961796942fcaef

Make sure that the content matches the content on notion: https://www.notion.so/Get-Involved-DONE-4dd998c0c13d428894961796942fcaef
a3thakra marked this conversation as resolved
a3thakra added 1 commit 2021-07-19 02:16:53 -04:00
continuous-integration/drone/push Build is passing Details
f2ca41f6d7
Address PR feedback
a3thakra reviewed 2021-07-19 03:32:23 -04:00
@ -0,0 +7,4 @@
import styles from "./get-involved.module.css";
/**
* @todo fix codey image with svg

? is it not fixed?

? is it not fixed?
a3thakra reviewed 2021-07-19 03:32:35 -04:00
@ -0,0 +70,4 @@
margin-top: calc(50rem / 16);
}
/* @todo aaaaaa */

is it still not fixed?

is it still not fixed?
a3thakra added 1 commit 2021-07-22 14:39:16 -04:00
continuous-integration/drone/push Build is passing Details
499e7865ba
Remove todos
a3thakra merged commit 360d9e4b6f into main 2021-07-22 14:42:40 -04:00
a3thakra referenced this issue from a commit 2021-07-22 14:42:40 -04:00
a3thakra deleted branch feat/get-involved-page 2021-07-22 14:42:48 -04:00
Sign in to join this conversation.
No reviewers
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: www/www-new#76
No description provided.