public
/
pyceo
27
1
Fork 3
Code Issues 25 Pull Requests 5 Projects Releases 1 Wiki Activity

Rewrite TUI #52

Merged
merenber merged 7 commits from tui-urwid into master 2022-05-22 14:09:48 -04:00
Conversation 4 Commits 7 Files Changed 116 +2333 -1733
merenber commented 2022-05-16 03:23:03 -04:00
Owner
Copy Link

Closes #44.
Closes #47.
Closes #49.
Closes #50.

The TUI has been rewritten using urwid instead of asciimatics. The MVC pattern was also used to help increase organization and readability.

The mouse has been disabled, which allows users to easily copy text from the terminal.

Terms are now sorted when displayed, for both the CLI and the TUI.

Closes #44. Closes #47. Closes #49. Closes #50. The TUI has been rewritten using urwid instead of asciimatics. The MVC pattern was also used to help increase organization and readability. The mouse has been disabled, which allows users to easily copy text from the terminal. Terms are now sorted when displayed, for both the CLI and the TUI.
merenber added 3 commits 2022-05-16 03:23:05 -04:00
continuous-integration/drone/pr Build is failing Details
88aec3e4ed fix lint errors
merenber added 1 commit 2022-05-16 11:39:28 -04:00
continuous-integration/drone/pr Build is passing Details
6a60b5242f update some dependencies
merenber requested review from r389li 2022-05-16 12:05:35 -04:00
merenber requested review from n3parikh 2022-05-16 12:05:35 -04:00
merenber commented 2022-05-16 12:06:38 -04:00
Author
Owner
Copy Link

There's a preview on corn-syrup if you want to test it out:

cd /scratch/merenber/pyceo
. venv/bin/activate
ceo
There's a preview on corn-syrup if you want to test it out: ``` cd /scratch/merenber/pyceo . venv/bin/activate ceo ```
merenber added 1 commit 2022-05-16 13:57:35 -04:00
continuous-integration/drone/pr Build is passing Details
643be9d5e1 allow PlainTextView to be scrollable
merenber requested review from r345liu 2022-05-21 08:43:47 -04:00
r345liu commented 2022-05-21 10:36:48 -04:00
Owner
Copy Link

Tried it on corn-syrup and is working. Functionality wise it LGTM.

The weird grid pattern in the background when terminal size is too big renders pretty badly on my screen (probably doesn't show in the screenshot). Does urwid only support fixed size? If making the tui responsive isn't possible, can the background colour be changed to a more solid one?

image

Also, clearning the terminal after quitting might not be a bad idea.

Tried it on corn-syrup and is working. Functionality wise it LGTM. The weird grid pattern in the background when terminal size is too big renders pretty badly on my screen (probably doesn't show in the screenshot). Does urwid only support fixed size? If making the tui responsive isn't possible, can the background colour be changed to a more solid one? ![image](/attachments/4c528b1a-f218-4cf8-94fd-d1d7e5861bcd) Also, clearning the terminal after quitting might not be a bad idea.
image.png
66 KiB
merenber added 1 commit 2022-05-21 11:17:50 -04:00
continuous-integration/drone/pr Build is passing Details
fe27ee7259 change background to light cyan
merenber added 1 commit 2022-05-21 11:23:23 -04:00
continuous-integration/drone/pr Build is passing Details
0dd53b0821 fix ColumnResponseView formatting
merenber commented 2022-05-21 11:25:39 -04:00
Author
Owner
Copy Link

Background was changed to light cyan.
Also fixed some formatting issues.

Background was changed to light cyan. Also fixed some formatting issues.
r345liu commented 2022-05-22 11:35:19 -04:00
Owner
Copy Link

Yep that looks a lot better now. LGTM

Yep that looks a lot better now. LGTM
merenber merged commit b543f0eb0c into master 2022-05-22 14:09:48 -04:00
merenber deleted branch tui-urwid 2022-05-22 14:09:48 -04:00
merenber referenced this issue from a commit 2022-05-22 14:09:49 -04:00
Rewrite TUI (#52)
Sign in to join this conversation.
Reviewers
No reviewers
r389li
n3parikh
r345liu
Labels
Clear labels   
priority
high
High priority

  
priority
low
Low priority

  
priority
medium
Medium priority

  
priority
very high
Very high priority

  
BUG

   
Feature

   
High Priority

   
Low Priority

   
Medium Priority
No Label
priority
high
priority
low
priority
medium
priority
very high
BUG
Feature
High Priority
Low Priority
Medium Priority
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: public/pyceo#52
No description provided.
Delete Branch "tui-urwid"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?